Should use strict comparison at line 71 in wp-admin/admin.php

[rnaby]

Well, the both side of comparison has already been same data type, but I think it would be better if the comparison would be strict !

Before or now the code looks like this-

if ( $c <= 50 || ( $c > 50 && mt_rand( 0, (int)( $c / 50 ) ) == 1 ) ) {

After fix the code looks like this-

if ( $c <= 50 || ( $c > 50 && mt_rand( 0, (int)( $c / 50 ) ) === 1 ) ) {

I think the later approach is better.

[rnaby]

The diff file I generated after fixing by RabbitVCS.

[dd32]

I don't I see any benefit in strict type checking in scenario's like this or #41988

As mt_rand() only returns int or false and we don't really need to care about any non-int return values, especially in this section of code.

A scenario where it would be useful is cases where "falsey" values are expected, such as #21249

What benefit does the proposed changes actually give?
FWIW our PHP Coding Standards are available here: ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/

[swissspidy]

Please note that there's also #41057 to fix coding standards in core once and for all. Much easier than having dozens of very small tickets for things not really worth fixing on their own.