WordPress.org

Make WordPress Core

Opened 5 weeks ago

Closed 4 weeks ago

Last modified 7 days ago

#42220 closed defect (bug) (fixed)

The draft page cannot see Customizing Homepage Settings makes Add New Page

Reported by: nukaga Owned by: westonruter
Milestone: 4.9 Priority: high
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch commit has-screenshots
Focuses: Cc:

Description

Customizing Homepage Settings → A static page → Add New Page → Save Draft
Pages cannot see the draft page.
I think that it is inconvenient.

Attachments (4)

Homepage Settings.png (775.1 KB) - added by nukaga 5 weeks ago.
Customizing Homepage Settings → A static page → Add New Page → Save Draft
pagesall.png (367.0 KB) - added by nukaga 5 weeks ago.
Pages have not draft
notice.png (84.4 KB) - added by westonruter 4 weeks ago.
display-post-states.png (107.2 KB) - added by westonruter 4 weeks ago.

Download all attachments as: .zip

Change History (19)

@nukaga
5 weeks ago

Customizing Homepage Settings → A static page → Add New Page → Save Draft

@nukaga
5 weeks ago

Pages have not draft

#1 @westonruter
5 weeks ago

  • Milestone changed from Awaiting Review to 4.9

You raise an interesting point. Technically the pages created have the auto-draft status, ensuring that they only appear in the context of a set of customized changes. When you do something in the Customizer, it should not have any impact outside the Customizer until you hit Publish. Nevertheless, we don't yet have a core workflow for editing posts and pages in the Customizer (while this is something you can do with the Customize Posts plugin). This is being explored in #39752 and will be a focus when integrations Gutenberg with customization. However, in the mean time I wonder if we should transition posts and pages created in the Customizer to drafts instead of auto-drafts if the changeset is saved as a draft or scheduled. Not only would this allow the user to edit it in the admin, but it would also fix a defect that I realize we didn't get incorporate from Customize Snapshots: when saving a changeset as a draft, the Customize Snapshots plugin will transition any such posts to a customized-draft so that they will not get garbage collected after a week like regular auto-drafts do. So we could do the same in core, to introduce this customized-draft status and then allow this status to appear in the post list tables. When editing such a post or page, we could also include a link to the Customizer to continue editing other changes in the changeset.

@melchoyce thoughts?

#2 @melchoyce
5 weeks ago

This is an interesting point, and a flow I hadn't considered.

However, in the mean time I wonder if we should transition posts and pages created in the Customizer to drafts instead of auto-drafts if the changeset is saved as a draft or scheduled.

I think so, yeah — it'll allow folks to draft or schedule changes, and then go and fill in copy before publishing, or going back to make additional customizations.

#3 @westonruter
5 weeks ago

  • Keywords needs-patch added
  • Owner set to westonruter
  • Priority changed from normal to high
  • Status changed from new to accepted

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


5 weeks ago

#7 @nukaga
5 weeks ago

Thank you for considering it!

#8 @westonruter
4 weeks ago

  • Keywords has-patch added; needs-patch removed

#9 @westonruter
4 weeks ago

  • Keywords commit added

@westonruter
4 weeks ago

#10 @westonruter
4 weeks ago

  • Keywords has-screenshots added

#11 @westonruter
4 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41887:

Customize: Allow post/page stubs to be edited in WP Admin as "customization drafts" when changeset is saved as draft or scheduled.

  • Update stubs to have draft status when changeset is saved as draft, instead of preventing auto-draft garbage collection by giving them a far-future post_date.
  • Show notice in publish metabox when editing a customization draft indicating that it will be published automatically with its changeset; a link to Customizer is included.
  • Include a new "Customization Draft" display post state in the post list table.
  • Disconnect stubs from their changesets when they are updated with a status other than "Draft".
  • Trash customization drafts when their related changeset is trashed or deleted.
  • Add a _customize_changeset_uuid postmeta to stubs to link them with their associated changeset.
  • Include customize_changeset_uuid as context when requesting to insert a new auto-draft.

Props westonruter, melchoyce.
See #39896, #39752, #34923.
Fixes #42220.

#12 @westonruter
4 weeks ago

In 41892:

Customize: Remove incorrect test assertions for the post_date of customization drafts.

Amends [41887].
See #42220.

This ticket was mentioned in Slack in #polyglots by nukaga. View the logs.


4 weeks ago

#14 @westonruter
7 days ago

In 42148:

Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).

Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721, #34923, #42220.
Fixes #42489 for trunk.

#15 @westonruter
7 days ago

In 42149:

Customize: Ensure customization drafts are published instead of trashed when scheduled changeset goes live while non-admin user is authenticated (such as during WP Cron).

Props designsimply for testing, dlh for testing, melchoyce for testing.
See #28721, #34923, #42220.
Fixes #42489 for 4.9.

Note: See TracTickets for help on using tickets.