#42220 closed defect (bug) (fixed)
The draft page cannot see Customizing Homepage Settings makes Add New Page
Reported by: | nukaga | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.9 | Priority: | high |
Severity: | normal | Version: | 4.9 |
Component: | Customize | Keywords: | has-patch commit has-screenshots |
Focuses: | Cc: |
Description
Customizing Homepage Settings → A static page → Add New Page → Save Draft
Pages cannot see the draft page.
I think that it is inconvenient.
Attachments (4)
Change History (19)
#1
@
7 years ago
- Milestone changed from Awaiting Review to 4.9
You raise an interesting point. Technically the pages created have the auto-draft
status, ensuring that they only appear in the context of a set of customized changes. When you do something in the Customizer, it should not have any impact outside the Customizer until you hit Publish. Nevertheless, we don't yet have a core workflow for editing posts and pages in the Customizer (while this is something you can do with the Customize Posts plugin). This is being explored in #39752 and will be a focus when integrations Gutenberg with customization. However, in the mean time I wonder if we should transition posts and pages created in the Customizer to drafts instead of auto-drafts if the changeset is saved as a draft or scheduled. Not only would this allow the user to edit it in the admin, but it would also fix a defect that I realize we didn't get incorporate from Customize Snapshots: when saving a changeset as a draft, the Customize Snapshots plugin will transition any such posts to a customized-draft
so that they will not get garbage collected after a week like regular auto-drafts do. So we could do the same in core, to introduce this customized-draft status and then allow this status to appear in the post list tables. When editing such a post or page, we could also include a link to the Customizer to continue editing other changes in the changeset.
@melchoyce thoughts?
#2
@
7 years ago
This is an interesting point, and a flow I hadn't considered.
However, in the mean time I wonder if we should transition posts and pages created in the Customizer to drafts instead of auto-drafts if the changeset is saved as a draft or scheduled.
I think so, yeah — it'll allow folks to draft or schedule changes, and then go and fill in copy before publishing, or going back to make additional customizations.
#3
@
7 years ago
- Keywords needs-patch added
- Owner set to westonruter
- Priority changed from normal to high
- Status changed from new to accepted
This ticket was mentioned in Slack in #core by melchoyce. View the logs.
7 years ago
#6
@
7 years ago
Work in progress PR: https://github.com/xwp/wordpress-develop/pull/287
#8
@
7 years ago
- Keywords has-patch added; needs-patch removed
@melchoyce Please review: https://github.com/xwp/wordpress-develop/pull/287#issuecomment-337151362
Customizing Homepage Settings → A static page → Add New Page → Save Draft