WordPress.org

Make WordPress Core

#42360 closed defect (bug) (fixed)

Customize: Deep-linking to themes section does not work

Reported by: westonruter Owned by: westonruter
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

As can be seen in #42354, in order to deep-link to a themes section you have to construct a URL like:

/wp-admin/customize.php?autofocus[panel]=themes&autofocus[section]=wporg_themes

It appears there is flaw in the ThemesSection#onChangeExpanded() method whereby it is not expanding its parent panel first.

One should be able to access a given section merely via /wp-admin/customize.php?autofocus[section]=wporg_themes

Introduced in #37661.

Attachments (1)

42360.0.diff (831 bytes) - added by westonruter 23 months ago.

Download all attachments as: .zip

Change History (6)

#1 @westonruter
23 months ago

  • Keywords has-patch added
  • Version set to trunk

#2 @westonruter
23 months ago

  • Owner set to celloexpressions
  • Status changed from new to reviewing

#3 @rinkuyadav999
23 months ago

Yes i notice that it takes a little time to open correct section.

#4 @celloexpressions
23 months ago

  • Owner changed from celloexpressions to westonruter

Looks good. As noted on the PR, on small screens, autofocusing to a section doesn't actually show the section contents. That's not critical, but it's a bit odd as it shows the section as checked within the panel, then you need to tap on it. Otherwise, looks ready to merge.

#5 @westonruter
23 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42033:

Customize: Fix deep-linking to sections for themes via autofocus[section] query parameter.

  • Expand containing panel when expanding themes section.
  • Consolidate UI changes related to a section's expanded state change.
  • Prevent collapsing current section when expanding.
  • Auto-expand first themes section when expanding panel if one is not expanded already.

See #37661, #42354.
Fixes #42360.

Note: See TracTickets for help on using tickets.