WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 21 months ago

Last modified 21 months ago

#42565 closed defect (bug) (fixed)

Customizer menu help text is incorrect

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

The help text shown in the Customizer after creating a new menu states:

Click “Add menu items” to start putting pages, categories, and custom links in your menu.

The actual button text says "Add Items", not "Add menu items".

Attachments (3)

42565.diff (1.1 KB) - added by munyagu 2 years ago.
42565.patch (1.1 KB) - added by rishishah 2 years ago.
42565.2.diff (1.5 KB) - added by dlh 2 years ago.

Download all attachments as: .zip

Change History (13)

@munyagu
2 years ago

#1 @munyagu
2 years ago

  • Keywords has-patch added; needs-patch removed

@rishishah
2 years ago

@dlh
2 years ago

#2 follow-up: @dlh
2 years ago

I have a question about good internationalization practices: Given that the help text is intended to show the literal button text, and not that same text in the context of the rest of the string, would it be preferable to insert the button text with sprintf()?

#3 in reply to: ↑ 2 @johnbillion
2 years ago

  • Component changed from Customize to Text Changes

Replying to dlh:

would it be preferable to insert the button text with sprintf()?

Yep. 42565.2.diff looks good.

#4 @johnbillion
2 years ago

  • Milestone changed from 4.9.1 to 4.9.2

This ticket was mentioned in Slack in #core by melchoyce. View the logs.


23 months ago

#6 @melchoyce
23 months ago

@johnbillion Looks good to me as well. Ready for commit?

#7 @johnbillion
23 months ago

  • Keywords commit added
  • Owner set to johnbillion
  • Status changed from new to reviewing

#8 @dd32
21 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

#9 @SergeyBiryukov
21 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 42568:

Customize: Correct "Add Items" button reference in help text shown after creating a new menu.

Props dlh, munyagu, rishishah.
Fixes #42565.

#10 @SergeyBiryukov
21 months ago

In 42569:

Customize: Correct "Add Items" button reference in help text shown after creating a new menu.

Props dlh, munyagu, rishishah.
Merges [42568] to the 4.9 branch.
Fixes #42565.

Note: See TracTickets for help on using tickets.