WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#42871 closed defect (bug) (fixed)

Features box textstrings in Feature Filter area need new linebreak

Reported by: westonruter Owned by: SergeyBiryukov
Milestone: 4.9.2 Priority: normal
Severity: normal Version: 4.9
Component: Customize Keywords: has-patch needs-testing
Focuses: Cc:

Description

Formerly #42306:

When the textstrings after the checkbox in the Features box (in: Customizer, Themes, Add New, Feature Filter) become to long, for example after their translation to german, the linebreak gets over 3 lines.

I've marked that blue in the attached screenshot.

Also, some of the orange marked strings are not ready for translation yet, but will probably become quite long in german too.

An indented linebreak over 2 lines after the checkbox would be nice here.

Attachments (2)

42871.patch (2.3 KB) - added by SergeyBiryukov 5 months ago.
42871.PNG (6.2 KB) - added by SergeyBiryukov 5 months ago.

Download all attachments as: .zip

Change History (8)

This ticket was mentioned in Slack in #core-customize by westonruter. View the logs.


5 months ago

#3 @westonruter
5 months ago

  • Keywords needs-testing added

@SergeyBiryukov
5 months ago

#4 @SergeyBiryukov
5 months ago

As noted in 6:ticket:42306, removing display: inline-block only partially fixes the issue, see https://core.trac.wordpress.org/attachment/ticket/42306/42306.png.

42871.patch fixes both horizontal and vertical alignment: 42871.PNG. Tested in Chrome, Firefox, Edge, IE 11.

Not a regression, but I don't see any issues with backporting it to 4.9.

#5 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42447:

Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.

Props chetan200891 for initial patch.
Fixes #42871.

#6 @SergeyBiryukov
5 months ago

In 42448:

Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.

Props chetan200891 for initial patch.
Merges [42447] to the 4.9 branch.
Fixes #42871.

Note: See TracTickets for help on using tickets.