WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 21 months ago

Last modified 21 months ago

#43088 closed defect (bug) (fixed)

The media modal main background should be white

Reported by: afercia Owned by: SergeyBiryukov
Milestone: 4.9.3 Priority: normal
Severity: normal Version: 4.9
Component: Media Keywords: has-screenshots
Focuses: ui Cc:
PR Number:

Description

In the media modal, the background of the content (the left part in the screenshots) used to be white:

https://cldup.com/D7CyqwdxSV.png

now is gray:

https://cldup.com/QtoUKpuUur.png

Introduced in [41833].

When working on the admin stylesheets, low qualified selectors like .attachment-media-view tend to apply to several screens and should always be double checked.

Attachments (3)

43088.diff (389 bytes) - added by chetan200891 21 months ago.
Created patch to make media modal main background white.
43088.2.diff (608 bytes) - added by afercia 21 months ago.
43088.3.diff (606 bytes) - added by afercia 21 months ago.

Download all attachments as: .zip

Change History (10)

@chetan200891
21 months ago

Created patch to make media modal main background white.

@afercia
21 months ago

#1 @chetan200891
21 months ago

Created patch 43088.diff to make media modal background white. It looks good to me!

#2 @afercia
21 months ago

@chetan200891 thanks! You beat me by 9 seconds, lol.

https://cldup.com/OLpqJRjp8G.png

However, the other backgrounds should stay gray (they're the "No image selected" placeholder in the widgets, see #42101).

#3 @chetan200891
21 months ago

@afercia Hahaha.. Yes.. But your patch is more better!

@afercia
21 months ago

#4 @afercia
21 months ago

43088.3.diff tries a simpler approach to keep the gray background for all the widget placeholders and restore the white background in the media modal. Also, removes a trailing space.

#5 @dd32
21 months ago

  • Milestone changed from 4.9.2 to 4.9.3

Bumping to 4.9.3 due to 4.9.2s release

#6 @SergeyBiryukov
21 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42572:

Media: Restore white background of the content area in media modal.

Props afercia, chetan200891.
Fixes #43088.

#7 @SergeyBiryukov
21 months ago

In 42573:

Media: Restore white background of the content area in media modal.

Props afercia, chetan200891.
Merges [42572] to the 4.9 branch.
Fixes #43088.

Note: See TracTickets for help on using tickets.