Network transients

[spacedmonkey]

Currently site (network) transients do not support multi network. For sites with object caching it stores the transient as a global and for sites without object caching, it stores it on the current networks options. This is a strange behavour, as object cached sites act very differet from none.

The behaviour should be the same on both types of site and how type of store a network transient should be better defined. Is it a global store or a network level store.

[johnjamesjacoby]

Patch looks great at a cursory. Needs deeper testing, so added a few keywords to that effect.

👍

[flixos90]

+1 for this change.

We should pay attention to how people may be using this, but I think the general perception has always been this is network-wide storage (storing in a global cache key seems like an oversight/bug to me). And since it only affects multi-network, we should be safe. I also like the direction of changing the function names and bringing them in line with the network option functions.

I agree this needs thorough testing as well and possibly further unit tests, but should be doable for 5.0.

[spacedmonkey]

43233.2.diff is a small bug fix, to make sure that $network_id param is always a int, and if not set, just use the current network id.

[flixos90]

We should hold off this until we've determined how to implement and solve the network meta / network option problem (see #37181).