Opened 7 years ago
Closed 7 years ago
#43317 closed defect (bug) (fixed)
Twenty Seventeen: Underline links in comments
Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-screenshots good-first-bug has-patch fixed-major |
Focuses: | ui, accessibility | Cc: |
Description
Twenty Seventeen removes default link underline and replaces it with box-shadow
:
a { text-decoration: none; } ... .entry-content a, .entry-summary a, .widget a, .site-footer .widget-area a, .posts-navigation a, .widget_authors a strong { -webkit-box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1); box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1); ... }
This is done for posts, widgets and navigation, but not for comments, so links in comments are indistinguishable from text. See the screenshot and try to find a link there :) (Hint: It's "Lorem ipsum".)
Haven't looked at other bundled themes yet.
Attachments (5)
Change History (15)
#2
@
7 years ago
Hi,
I try my first patch on WP core, I hope everything is OK.
Cheers from France.
Rachel
#3
@
7 years ago
Hi,
I tested this bug from TwentyTen to TwentySeventeen and it occurs only in the last bundled theme, TwentySeventeen @SergeyBiryukov
I have no fixed idea about the best way to insert this fix in TwentySeventeen stylesheet but both of the proposed patches seems good to me.
Cheers,
Jb
#4
@
7 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 42713:
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
7 years ago
#6
@
7 years ago
- Milestone changed from 5.0 to 4.9.5
Moving forward into the 4.9.5 release as per today's bug scrub.
#7
@
7 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
fix link underline in comments