Opened 8 years ago
Closed 8 years ago
#43317 closed defect (bug) (fixed)
Twenty Seventeen: Underline links in comments
| Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9.5 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-screenshots good-first-bug has-patch fixed-major |
| Cc: | Focuses: | ui, accessibility |
Description
Twenty Seventeen removes default link underline and replaces it with box-shadow:
a {
text-decoration: none;
}
...
.entry-content a,
.entry-summary a,
.widget a,
.site-footer .widget-area a,
.posts-navigation a,
.widget_authors a strong {
-webkit-box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);
box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);
...
}
This is done for posts, widgets and navigation, but not for comments, so links in comments are indistinguishable from text. See the screenshot and try to find a link there :) (Hint: It's "Lorem ipsum".)
Haven't looked at other bundled themes yet.
Attachments (5)
Change History (15)
#2
@
8 years ago
Hi,
I try my first patch on WP core, I hope everything is OK.
Cheers from France.
Rachel
#3
@
8 years ago
Hi,
I tested this bug from TwentyTen to TwentySeventeen and it occurs only in the last bundled theme, TwentySeventeen @SergeyBiryukov
I have no fixed idea about the best way to insert this fix in TwentySeventeen stylesheet but both of the proposed patches seems good to me.
Cheers,
Jb
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
8 years ago
#6
@
8 years ago
- Milestone 5.0 → 4.9.5
Moving forward into the 4.9.5 release as per today's bug scrub.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
fix link underline in comments