WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#43317 closed defect (bug) (fixed)

Twenty Seventeen: Underline links in comments

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.9.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots good-first-bug has-patch fixed-major
Focuses: ui, accessibility Cc:

Description

Twenty Seventeen removes default link underline and replaces it with box-shadow:

a {
	text-decoration: none;
}

...

.entry-content a,
.entry-summary a,
.widget a,
.site-footer .widget-area a,
.posts-navigation a,
.widget_authors a strong {
	-webkit-box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);
	box-shadow: inset 0 -1px 0 rgba(15, 15, 15, 1);
	...
}

This is done for posts, widgets and navigation, but not for comments, so links in comments are indistinguishable from text. See the screenshot and try to find a link there :) (Hint: It's "Lorem ipsum".)

Haven't looked at other bundled themes yet.

Attachments (5)

43317.PNG (24.0 KB) - added by SergeyBiryukov 3 months ago.
43317.diff (992 bytes) - added by jainnidhi 3 months ago.
43317.2.diff (601 bytes) - added by larrach 3 months ago.
fix link underline in comments
43317.3.diff (714 bytes) - added by larrach 3 months ago.
proper position for the css rule
43317.4.diff (875 bytes) - added by jainnidhi 3 months ago.
I've fixed the position of css rule in this patch.

Download all attachments as: .zip

Change History (15)

@SergeyBiryukov
3 months ago

@jainnidhi
3 months ago

#1 @jainnidhi
3 months ago

  • Keywords has-patch added; needs-patch removed

@larrach
3 months ago

fix link underline in comments

@larrach
3 months ago

proper position for the css rule

#2 @larrach
3 months ago

Hi, I try my first patch on WP core, I hope everything is OK. Cheers from France. Rachel

@jainnidhi
3 months ago

I've fixed the position of css rule in this patch.

#3 @audrasjb
3 months ago

Hi,

I tested this bug from TwentyTen to TwentySeventeen and it occurs only in the last bundled theme, TwentySeventeen @SergeyBiryukov I have no fixed idea about the best way to insert this fix in TwentySeventeen stylesheet but both of the proposed patches seems good to me.

Cheers, Jb

#4 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42713:

Twenty Seventeen: Underline links in comments.

Props jainnidhi, larrach, audrasjb.
Fixes #43317.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 months ago

#6 @danieltj
2 months ago

  • Milestone changed from 5.0 to 4.9.5

Moving forward into the 4.9.5 release as per today's bug scrub.

#7 @danieltj
2 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 months ago

#10 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 42859:

Twenty Seventeen: Underline links in comments.

Props jainnidhi, larrach, audrasjb.
Merges [42713] to the 4.9 branch.
Fixes #43317.

Note: See TracTickets for help on using tickets.