Ensure only sidebar sections are considered when comparing against registered sidebars in Customizer

[flixos90]

In the Customizer's widgets panel, commonly sections for each registered sidebar are added. However, it is possible to also register regular sections to it, for example it may be useful to add one general settings section related to more general sidebar behavior.

For the most part this works seamlessly, there is just one detail I noticed. Commonly a notice will show in the Customizer if there is at least one registered sidebar that cannot be displayed for the currently previewed page. However this check counts all sections in the panel and compares them to the number of registered sidebars, where it should actually only count the sections that are actually intended to represent sidebars.

In my personal example, I added one additional section of type default, and there was one section of type sidebar which could not be displayed for the currently previewed page. However, since my default section was active, the count matched the registered sidebar count again, causing the notice to falsely not display.

[flixos90]

43556.diff​ ensures that only sections of the type sidebar are counted, to fix this bug.

[joyously]

I think I was seeing this same thing, only I wasn't creating other sections or sidebars, so I was thinking it was counting the Inactive Widget Area when it shouldn't. Does your patch account for that?

[westonruter]

43556.diff​ makes sense to me.

I was thinking it was counting the Inactive Widget Area when it shouldn't

@joyously There shouldn't be a section registered for inactive widget areas: ​https://github.com/WordPress/wordpress-develop/blob/7c2f975/src/wp-includes/class-wp-customize-widgets.php#L428-L468

There _is_ as setting registered for the inactive widgets sidebar, however.

[flixos90]

@westonruter Is this missing anything or good to go?

[westonruter]

@flixos90 it looks good to go. Engage.

[flixos90]

In 43588:

Customize: Ensure that only sidebar sections are considered when comparing against sidebars.

In the Customizer a notice will show up if there is at least one registered sidebar with its section not being active. In order to achieve that, the count of registered sidebars is compared to the count of active sections in the Widgets panel. Prior to this change, the latter would incorrectly include any sections, even additional sections that do not correspond to a sidebar.

Fixes #43556.