WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 weeks ago

#43628 closed defect (bug) (fixed)

Twenty Seventeen: Post title's margin-bottom on front page is too large

Reported by: hirofumi2012 Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: ui, css Cc:

Description

Post title's margin-bottom is 4em when set a posts in page and choose 1 column.
It is too large.

So we need to add a css like this:

@media screen and (min-width: 48em) {
  .page.page-one-column .recent-posts .entry-header,
  .twentyseventeen-front-page.page-one-column .recent-posts .entry-header{
    margin-bottom: 1.5em;
  }
}

may be...

Attachments (5)

settings.png (123.3 KB) - added by jainnidhi 4 years ago.
Set the page layout to one column and select blog page in front page section.
large-gap.png (116.9 KB) - added by jainnidhi 4 years ago.
It shows more gap in between title and content.
43628.diff (530 bytes) - added by jainnidhi 4 years ago.
I've reduced space in between title and content in this patch.
40457.patch (456 bytes) - added by sabernhardt 6 weeks ago.
Makes blog header margin more specific on front page when layout is set to one column
40457.2.patch (456 bytes) - added by sabernhardt 6 weeks ago.
Makes blog header margin more specific on front page when layout is set to one column

Download all attachments as: .zip

Change History (14)

#1 @swissspidy
4 years ago

  • Keywords needs-screenshots added

@jainnidhi
4 years ago

Set the page layout to one column and select blog page in front page section.

@jainnidhi
4 years ago

It shows more gap in between title and content.

@jainnidhi
4 years ago

I've reduced space in between title and content in this patch.

#2 follow-up: @jainnidhi
4 years ago

  • Keywords has-screenshots has-patch added; needs-screenshots removed

#3 in reply to: ↑ 2 @hirofumi2012
4 years ago

Replying to jainnidhi:
Thank you for adding screenshots.
This is perfect for me.

#4 @SergeyBiryukov
3 years ago

  • Summary changed from Twenty Seventeen front page - post title's margin-bottom is too large. to Twenty Seventeen: Post title's margin-bottom on front page is too large

#5 @laurelfulford
3 years ago

  • Version changed from trunk to 4.7

#6 @sabernhardt
6 weeks ago

#40457 was marked as a duplicate.

@sabernhardt
6 weeks ago

Makes blog header margin more specific on front page when layout is set to one column

@sabernhardt
6 weeks ago

Makes blog header margin more specific on front page when layout is set to one column

#7 @sabernhardt
6 weeks ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.9

I prefer @laurelfulford's 40457.patch for this.

I only see the .panel-content .recent-posts .entry-header selector's elements together on the front page, and making that more specific with the .twentyseventeen-front-page body class is simpler than adding new rules.

Last edited 6 weeks ago by sabernhardt (previous) (diff)

#8 @mukesh27
6 weeks ago

  • Keywords commit added

Thanks for the patch.

40457.patch working fine for me.

Marking this ticket for commit.

#9 @SergeyBiryukov
2 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51808:

Twenty Seventeen: Make blog header margin more specific on front page.

This avoids a large gap between title and content when the layout is set to one column.

Props laurelfulford, sabernhardt, hirofumi2012, jainnidhi, mukesh27.
Fixes #43628.

Note: See TracTickets for help on using tickets.