WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#43934 closed defect (bug) (fixed)

Missing doc for the user_request_key_expiration filter

Reported by: birgire's profile birgire Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: good-first-bug gdpr has-patch commit
Focuses: docs, administration Cc:

Description

The user_request_key_expiration filter here:

​https://github.com/WordPress/WordPress/blob/64192e967e7b7f158fbbcbf343a0044816be45f8/wp-admin/includes/user.php#L756

is missing the inline documentation. It's actually a duplicated hook, that's documented here:

​https://github.com/WordPress/WordPress/blob/64192e967e7b7f158fbbcbf343a0044816be45f8/wp-includes/user.php#L3222

so we need this line:

/** This filter is documented in /wp-includes/user.php */

Attachments (1)

43934.diff​ (532 bytes) - added by desrosj 7 years ago.

Download all attachments as: .zip

Change History (6)

#1 @ocean90
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9.6

@desrosj
7 years ago

#2 @desrosj
7 years ago

  • Keywords has-patch commit added; needs-patch removed

#3 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43168:

Docs: Add missing duplicate hook comment for user_request_key_expiration filter.

Props birgire, desrosj.
Fixes #43934.

#4 @SergeyBiryukov
7 years ago

In 43169:

Docs: Add missing duplicate hook comment for user_request_key_expiration filter.

Props birgire, desrosj.
Merges [43168] to the 4.9 branch.
Fixes #43934.

#5 @desrosj
7 years ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.