WordPress.org

Make WordPress Core

Opened 11 days ago

Closed 9 days ago

Last modified 7 days ago

#44057 closed defect (bug) (fixed)

It's not obvious what to do if menu bubble for policy update appears

Reported by: ocean90 Owned by: azaozz
Milestone: 4.9.6 Priority: high
Severity: normal Version: trunk
Component: Privacy Keywords: ux-feedback gdpr has-patch commit
Focuses: Cc:

Description

[43223] introduced a menu bubble notification for policy updates and mentions that the page "provides an explanation of why the bubble is appearing.".

I think that explanation needs to be improved because I had no idea what do to get the bubble removed.

First try: Since the notice on the privacy page mention that I should update my privacy policy I went straight to the edit screen of the privacy policy. At this point I still had no idea about what has changed. So I just clicked the update button and took a look at the page on the frontend. After going back into the admin the bubble was gone.

Second try: This time I clicked on the "check out our guide" link on the privacy page even through the text itself doesn't mention that it also include updates. To be honest, I wasn't even sure if it includes texts by plugins/themes because of the "our" part (until reading to the end of the sentence). In the ToC box of the guide I noticed a small "Updated" label. That's nice if you have just one plugin extending the content. Since the "Updated" labels appear to remain, it may get unclear which policy really has changed. On this page I was missing a link to get to my policy page where I can paste the changes. So I went to Pages, searched for my page and finally being on the edit screen I noticed that the bubble was gone again. A bit unexpected because my policy wasn't updated yet.

Third try: I gave up On the privacy page I clicked on the small Edit link to get to my policy page. On this page I opened the "check out our guide" link in a new window. Using split screen I now had both pages open. Once I was done, I saved the updated policy and - as expected - the menu bubble was gone too. Mission accomplished.


What can we do to make updating the policy more clear? As a first step I'd suggest to mention that the guide includes the changes. That can be done on the notice itself:

- Please update your privacy policy.
+ Please review the guide and update your privacy policy.

Then, on the guide, add a link to user's policy page so they don't have to search for it.

Attachments (2)

44057.patch (722 bytes) - added by azaozz 10 days ago.
44057.2.diff (733 bytes) - added by birgire 9 days ago.

Download all attachments as: .zip

Change History (14)

#1 @iandunn
11 days ago

  • Keywords gdpr added

#2 @azaozz
10 days ago

  • Priority changed from normal to high

Yeah, we went through several iterations before arriving at using mostly "the bubble" and not showing notices/warnings. That made it harder to figure out what's expected and what's updated...

In addition to the above text change, I also think we should be removing the bubble only when the Privacy Policy Guide screen gets loaded, and stop removing it when the privacy policy page gets saved/updated. This seems more logical: the bubble indicates that the guide has some new or updated content and the admin/site owner has to see it to remove the bubble.

Patch coming up.

#3 @azaozz
10 days ago

Seems better to split this. Created #44063 for the bubble removal bug.

@azaozz
10 days ago

#4 @azaozz
10 days ago

  • Keywords has-patch added; needs-patch removed

In 44057.patch: add the above text change and also add a link to the Privacy Policy Guide screen.

@birgire
9 days ago

#6 @ocean90
9 days ago

In 43261:

Privacy: Remove is-dismissible class from notice when privacy info has changed.

The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Fixes #44065.

#7 @ocean90
9 days ago

In 43262:

Privacy: Remove is-dismissible class from notice when privacy info has changed.

The notice isn't dismissible as it only gets removed once you visit the privacy guide, see #44057 and #44063.

Merge of [43260] to the 4.9 branch.

See #44065.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


9 days ago

#9 @ocean90
9 days ago

  • Keywords commit added

44057.2.diff looks good to me.

#10 @azaozz
9 days ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43263:

Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.

Props birgire, azaozz.
Fixes #44057.

#11 @azaozz
9 days ago

In 43264:

Privacy: fix the "Privacy Policy Guide updated" message and add a link to the guide.

Props birgire, azaozz.
Merges [43263] to the 4.9 branch.
Fixes #44057.

#12 @desrosj
7 days ago

  • Component changed from Administration to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.