Adding fields to comments_form args prevents checkbox displaying

[pross]

Steps to reproduce:

in a comments.php pass the $args to comments_form

comment_form( array(
        'fields' => array(
            'author' => 'Hello World!',
        ),
));

Because fields is now set the privacy checkbox will never display.

comment-template.php needs to check whether fieldscookies is set.

[desrosj]

Thanks for the ticket, @pross. I tested this and I am able to reproduce.

I am going to add this to the dev note for themes that are providing arguments to comment_form(). If a theme is overriding the fields in core, I think this should be on them to add the new field. But we need to help them understand why and how. I did notice that the docblock is missing the new field, though.

We could also separate the display of this field into a different argument.

Going to mark 4.9.7 for now so that this gets looked at.

[desrosj]

Added to the ​Changes that Affect Theme Authors in WordPress 4.9.6 dev note.

[pross]

Quick patch, still allows users to use comment_form_default_fields so they can still remove the cookies checkbox if need be.

[desrosj]

Moving all tickets in 4.9.7 to 4.9.8.

[SergeyBiryukov]

Previously: #32312

Something similar to [32511] should probably be done here.

[SergeyBiryukov]

On second thought, 44126.patch​ makes more sense.

[SergeyBiryukov]

The patch should take [43370] and [43469] into account though.

[SergeyBiryukov]

In 43518:

Comments: Ensure that themes overriding default comment_form() fields still display the cookies consent checkbox.

The comment_form_default_fields filter can be used to remove the checkbox.

Props pross, SergeyBiryukov.
Fixes #44126.

[SergeyBiryukov]

In 43524:

Comments: Ensure that themes overriding default comment_form() fields still display the cookies consent checkbox.

The comment_form_default_fields filter can be used to remove the checkbox.

Props pross, SergeyBiryukov.
Merges [43518] to the 4.9 branch.
Fixes #44126.