WordPress.org

Make WordPress Core

Opened 12 days ago

Last modified 12 days ago

#44328 new defect (bug)

grunt watch does not include cssmin; changes to css files in src are copied to build but not minified

Reported by: allendav Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: Cc:

Description

If you make a change to a css file, e.g. src/wp-admin/css/forms.css while grunt watch is running, the change will be copied to build/wp-admin/css/forms.css but build/wp-admin/css/forms.min.css is not updated

It is necessary to independently run grunt cssmin to get the minified css files updated.

Change History (3)

This ticket was mentioned in Slack in #core-privacy by allendav. View the logs.


12 days ago

#2 @netweb
12 days ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0

Historically the Grunt watch tasks did not run the CSS and JS minify tasks as SCRIPT_DEBUG was defined true when developing in the src folder.

With the new build process JS files are minified as part of the watch task, we should do the same for CSS files

#3 @azaozz
12 days ago

Ideally both SCRIPT_DEBUG and WP_DEBUG should be enabled when developing. Perhaps best would be if we can force these when doing grunt watch. This will also let us stop minifying js files while "watching" to save some CPU cycles :)

Last edited 12 days ago by azaozz (previous) (diff)
Note: See TracTickets for help on using tickets.