#44424 closed task (blessed) (fixed)
PHPDoc comments and @return tags missing at many places
| Reported by: | subrataemfluence | Owned by: | swissspidy |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.5 |
| Component: | I18N | Version: | |
| Severity: | minor | Keywords: | has-patch good-first-bug |
| Cc: | Focuses: | docs, coding-standards |
Description
Function/methods and property declarations are missing PHPDoc comment and @return tags at many places of src/wp-includes/pomo/translations.php
Proposed patch added.
Attachments (1)
Change History (12)
#3
@
8 years ago
- Keywords needs-refresh added
Reviewing 44424.diff:
$entriesand$headerscould do with descriptions.get_header()returns a header, not an element.translate_entry()returns an entry, not an element.select_plural_form()returnsint, and the return needs a description.translate_plural()only returns astring. The params and return need a description.gettext_select_plural_form()returns the result of calling the callable thatmake_plural_form_function()returns. The callable thatmake_plural_form_function()returns will return anint.make_plural_form_function()returns acallable.- All of the docblocks added to
NOOP_Translationsneed descriptions.
#7
@
3 years ago
You can, but it's not a requirement. People reading through the comments here will see that you're working on it regardless :-)
Just remember to follow the PHP documentation standards
This ticket was mentioned in PR #5212 on WordPress/wordpress-develop by @hrshahin.
3 years ago
#8
- Keywords needs-refresh removed
Trac ticket: https://core.trac.wordpress.org/ticket/44424
Description :
Add missing PHPDoc comments and @return tags in many places.
Changes:
Class Translations:
Manages translation entries and headers.
Methods for adding entries, setting headers, translating, and merging entries.
Class Gettext_Translations (extends Translations):
Extends Translations with gettext-specific functionality.
Handles plural forms and expressions for gettext translations.
Class NOOP_Translations:
Provides a placeholder class with the same interface as Translations but no actual translation operations.
#9
@
3 years ago
- Milestone Future Release → 6.5
- Owner set to
- Severity normal → minor
- Status new → reviewing
- Type defect (bug) → task (blessed)
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Proposed patch