Opened 3 years ago
Last modified 2 years ago
#44424 new defect (bug)
PHPDoc comments and @return tags missing at many places
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch needs-refresh |
Focuses: | docs, coding-standards | Cc: |
Description
Function/methods and property declarations are missing PHPDoc comment and @return
tags at many places of src/wp-includes/pomo/translations.php
Proposed patch added.
Attachments (1)
Change History (5)
#1
@
3 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 5.0
#3
@
2 years ago
- Keywords needs-refresh added
Reviewing 44424.diff:
$entries
and$headers
could do with descriptions.get_header()
returns a header, not an element.translate_entry()
returns an entry, not an element.select_plural_form()
returnsint
, and the return needs a description.translate_plural()
only returns astring
. The params and return need a description.gettext_select_plural_form()
returns the result of calling the callable thatmake_plural_form_function()
returns. The callable thatmake_plural_form_function()
returns will return anint
.make_plural_form_function()
returns acallable
.- All of the docblocks added to
NOOP_Translations
need descriptions.
Note: See
TracTickets for help on using
tickets.
Proposed patch