Opened 5 years ago
Last modified 3 years ago
#44515 new defect (bug)
Multisite: "Deactivate" And "Delete" Labels Are Confusing
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | 4.9.6 |
Component: | Networks and Sites | Keywords: | |
Focuses: | multisite | Cc: |
Description
Problem: Some of our admins accidentally "Deleted" their sites when all they really wanted to do was "Delete" their site. (?!)
wp-admin/network/sites.php
- "Deactivate" sets delete column to 1 in wp_blogs, recoverable action.
- "Delete" runs wpmu_delete_blog() with
$drop = true
, unrecoverable action.
wp-admin/network/site-info.php?id=2
- "Deleted" sets delete column to 1 in wp_blogs, recoverable action.
Suggestion: Change "Deleted" to "Deactivated"
$attribute_fields['deleted'] = __( 'Deactivated' );
'deleted' => array( 'site-deleted', __( 'Deactivated' ) ),
Attachments (1)
Change History (5)
#4
@
3 years ago
- Type changed from enhancement to defect (bug)
Additionally, when a site is deactivated and it shows up in the site list highlighted in red, it should say "deactivated" and not "deleted".
I disagree that this is an enhancement rather than a defect, because it is a conflation of two very distinct, widely understood English words. The implications of an admin making this mistake, which specifically would only happen because WP core confusingly misuses "delete" to mean "deactivate" in a few different areas, are both startling and destructive.
I agree that some more clarity on this would be nice.