Optimize `get_the_post_thumbnail_url` call

[soulseekah]

This function merely returns the post meta using the post ID. In cases where an ID is passed there's no need to fetch the complete WP_Post object, use it directly as the post ID in the get_post_meta call.

[birgire]

It looks like some dbdelta changes came through with the patch.

[soulseekah]

@birgire Eek, cached diff changes from another ticket I was working on. Thanks for noticing! Replaced.

[SergeyBiryukov]

Hi @soulseekah, thanks for the patch! get_post() was introduced in [34167].

Do you have any performance benchmarks for this change? get_post() calls are cached, so I don't expect there to be a huge difference.

The current code has an additional benefit of validating if the post exists before calling get_post_meta(). With the patch, the return value type changes from an empty string to a boolean false. This would need to be reflected in the docs and could be a potential back compat issue if someone only accounts for the (currently documented) string value in their code.

[flixos90]

+1 to what @SergeyBiryukov says. I would expect any performance impact here to be negligible, and the benefit of calling get_post() helps ensure that the provided post ID is actually valid.

I would therefore advise to close this ticket.