WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 4 months ago

#44771 closed task (blessed) (fixed)

Update Travis CI build matrix for PHP 7.3

Reported by: desrosj Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch php73
Focuses: Cc:

Description

PHP 7.3 has entered the beta stages. This is causing the nightly build on Travis to test 7.4.0-dev and not 7.3.

PHP 7.3 compatibility tickets have been added to 5.0, so as soon as Travis makes the image available, it should be added to the build matrix to be properly tested. Until deemed fully 7.3 compatible, the build can be allowed to fail.

Attachments (3)

44771.diff (445 bytes) - added by jorbin 8 months ago.
44771.2.diff (947 bytes) - added by jorbin 7 months ago.
44771.3.diff (991 bytes) - added by desrosj 6 months ago.

Download all attachments as: .zip

Change History (27)

@jorbin
8 months ago

#1 @jorbin
8 months ago

  • Keywords has-patch added

Waiting for Travis to actually support 7.3 builds, but patch is ready.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


7 months ago

#3 @johnbillion
7 months ago

  • Type changed from defect (bug) to task (blessed)

This ticket was mentioned in Slack in #core by desrosj. View the logs.


7 months ago

@jorbin
7 months ago

#5 follow-up: @jorbin
7 months ago

  • Milestone changed from 5.0 to 4.9.9

Travis still hasn't added 7.3 to the official build list, but based on comments on https://github.com/travis-ci/travis-ci/issues/9717 I've been able to devise a way for us to run tests on it. See the above patch and https://travis-ci.org/WordPress/wordpress-develop/jobs/436444295

With this landing we can focus on the remaining 7.3 issues.

#6 in reply to: ↑ 5 @netweb
7 months ago

  • Keywords commit added

Works for me, matches other implementations I've seen in the past few days 👌

Commit away @jorbin

#7 follow-up: @desrosj
7 months ago

I believe we can up the test version to RC2 now that it is merged into php-build

#8 in reply to: ↑ 7 @netweb
7 months ago

Replying to desrosj:

I believe we can up the test version to RC2 now that it is merged into php-build

Even better, it would be good to update https://github.com/WordPress/wordpress-develop/pull/18 to confirm

#9 @desrosj
7 months ago

It appears there is still a piece missing somewhere blocking RC2 being used. The package is not built on the Travis S3 account (https://s3.amazonaws.com/travis-php-archives/binaries/ubuntu/16.04/x86_64/php-7.3.0RC2.tar.bz2).

Let's just roll with RC1 for now.

#10 @jorbin
7 months ago

In 43673:

Build/Test Tools: Add PHP7.3 RC1 to the build matrix

Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: https://github.com/travis-ci/travis-ci/issues/9717

See #44771.

#11 @pento
7 months ago

  • Milestone changed from 4.9.9 to 5.0

[43673] can be ported to the 5.0 branch, if it's needed while we wait for Travis to make PHP 7.3 packages available.

#12 @johnbillion
6 months ago

In 43692:

Build/Test Tools: Add PHP7.3 RC1 to the build matrix

Currently, we need to do some extra steps to run 7.3, but this will help us with testing compatibility.

See: https://github.com/travis-ci/travis-ci/issues/9717

See #44771.

Merges [43673] to the 5.0 branch.

#13 @johnbillion
6 months ago

  • Keywords commit removed

Merged [43673] into 5.0. Leaving this ticket open for further changes to accommodate 7.3 testing.

#14 @desrosj
6 months ago

On Travis, `7.3` now aliases to `7.3.0RC3`. The extra steps originally added in [43673] can now be removed in favor of the same approach used for other versions of PHP.

Test build showing 7.3.0RC3 is used.

Incoming patch with the needed changes.

@desrosj
6 months ago

#15 @netweb
6 months ago

@desrosj I'm not sure if there are any differences between the current .travis.yml files for /trunk and 5.0 but just in case there is (I didn't look) would you mind also adding a patch for the 5.0 branch (a follow up to [43692]) please

#16 @jorbin
6 months ago

In 43726:

Build/Test Tools: Use 7.3 for PHP 7.3

Travis now supports PHP7.3 without workarounds, so let's remove the workarounds.

Previously [43692].

See #44771.

#17 follow-up: @desrosj
6 months ago

@netweb 44771.3.diff should also apply cleanly for 5.0.

#18 in reply to: ↑ 17 @netweb
6 months ago

Replying to desrosj:

@netweb 44771.3.diff should also apply cleanly for 5.0.

Cool 👍

@jorbin can you also commit this for /trunk please

#19 follow-up: @jorbin
6 months ago

  • Keywords fixed-5.0 added

@netweb no. Trunk is closed as of https://make.wordpress.org/core/2018/10/05/wordpress-5-0-commit-management/

@desrosj Sorry, missed your patch earlier when I did this.

#20 in reply to: ↑ 19 @netweb
6 months ago

Replying to jorbin:

@netweb no. Trunk is closed as of https://make.wordpress.org/core/2018/10/05/wordpress-5-0-commit-management/

Ha, I think I knew that 😉, I just need to remember it now 😏

#21 @desrosj
6 months ago

  • Keywords php73 added

#22 @desrosj
5 months ago

[43899] contained the last known 7.3 incompatibility fix and removed 7.3 from the allowed failures list in Travis.

This can now be considered complete.

#23 @jorbin
4 months ago

In 43975:

Build/Test Tools: Use 7.3 for PHP 7.3

Travis now supports PHP7.3 without workarounds, so let's remove the workarounds.

Merges [43726] to trunk.

See #44771.

#24 @desrosj
4 months ago

  • Keywords fixed-5.0 removed
  • Resolution set to fixed
  • Status changed from new to closed

PHP 7.3 was removed from the allowed_failures list when [43899] was merged into trunk in [44167].

Note: See TracTickets for help on using tickets.