Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#44770 closed defect (bug) (fixed)

Customize: `option_{$option}` filter applied with a missing parameter

Reported by:	dlh	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.0.3
Component:	Customize	Version:	4.4
Severity:	normal	Keywords:
Cc:		Focuses:

Description

WP_Customize_Widgets::capture_filter_pre_get_option() applies the option_{$option} filter to the captured value, but without the second $option parameter added in WordPress 4.4.

The missing parameter has the potential to generate fatal errors in PHP 7.1 and above from uncaught ArgumentCountError exceptions if a function is hooked to the filter that accepts both parameters.

The attached patch would add the second parameter to the apply_filters() call.

Attachments (1)

44770.diff (587 bytes ) - added by dlh 8 years ago.

Download all attachments as: .zip

Change History (12)

@dlh
8 years ago

Attachment 44770.diff added

#1 @westonruter
8 years ago

Keywords commit added
Milestone Awaiting Review → 4.9.9

Good catch.

#2 @SergeyBiryukov
8 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Customize: Pass missing parameter to dynamic option_{$option} filter in WP_Customize_Widgets::capture_filter_pre_get_option().

Props dlh.
Fixes #44770.

#3 @SergeyBiryukov
8 years ago

Keywords fixed-major added
Resolution fixed
Status closed → reopened

Reopening for 4.9.9 consideration.

#4 @SergeyBiryukov
8 years ago

Resolution → fixed
Status reopened → closed

Customize: Pass missing parameter to dynamic option_{$option} filter in WP_Customize_Widgets::capture_filter_pre_get_option().

Props dlh.
Fixes #44770.

#5 @pento
8 years ago

Resolution fixed
Status closed → reopened

[43611] needs to be reverted from the 4.9 branch. This issue should then be milestoned for 5.0.1.

#6 @SergeyBiryukov
8 years ago

Customize: Revert [43611] from the 4.9 branch.

This change is out of the 4.9.x scope, and will be reintroduced in 5.0.x.

#7 @SergeyBiryukov
8 years ago

Milestone 4.9.9 → 5.0.1

#8 @pento
8 years ago

Milestone 5.0.1 → 5.0.2

#9 @pento
8 years ago

Milestone 5.0.2 → 5.0.3

#10 @desrosj
8 years ago

Resolution → fixed
Status reopened → closed

Customize: Pass missing parameter to dynamic option_{$option} filter in WP_Customize_Widgets::capture_filter_pre_get_option().

This prevents a potential fatal error from an ArgumentCountError exception in PHP 7.1 or greater

Props dlh.

Merges [43561] to the 5.0 branch.
Fixes #44770.

#11 @desrosj
8 years ago

Keywords has-patch commit fixed-major removed

Note: See TracTickets for help on using tickets.

Download in other formats: