WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#44812 closed defect (bug) (fixed)

Undefined variable unset

Reported by: hitendra-chopda's profile Hitendra Chopda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

I have checked out that the variable name $title_class is undefined and used it for unset.

Attachments (2)

admin-header.php.patch​ (775 bytes) - added by Hitendra Chopda 6 years ago.
This is patch file
44812.diff​ (442 bytes) - added by torontodigits 6 years ago.
Patch refreshed

Download all attachments as: .zip

Change History (7)

@Hitendra Chopda
6 years ago

This is patch file

#1 @torontodigits
6 years ago

  • Keywords 2nd-opinion added

Hello @hitendra-chopda,

Welcome to the Trac.

Thanks for reporting the bug.

Regarding the admin_body_class filter I don't think there should be inline documentation for $admin_body_classes parameter as this filter takes only on parameter and it is already documented.

I have refreshed the patch accordingly. Let's wait for second opinion as well.

Thanks

Last edited 6 years ago by torontodigits (previous) (diff)

@torontodigits
6 years ago

Patch refreshed

#2 @SergeyBiryukov
6 years ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 5.0

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43573:

Administration: Remove $title_class variable, unused since [18683].

Props hitendra-chopda, torontodigits.
Fixes #44812.

#5 @pento
6 years ago

  • Milestone changed from 5.0 to 5.1
Note: See TracTickets for help on using tickets.