_get_list_table: Support for privacy requests tables

[birgire]

The admin table classes are served with _get_list_table().

I wonder if we should add a support for the classes:

• WP_Privacy_Data_Export_Requests_Table
• WP_Privacy_Data_Removal_Requests_Table

in _get_list_table() for consistency.

[desrosj]

I like this idea, and the patch looks good. But, unfortunately, this is blocked by two issues.

First, _get_list_table() will try to include wp-admin/includes/class-wp-' . $required . '-list-table.php, which does not exist yet (see #43895).

Second, there is a problem with the privacy request class table names that will need to be resolved. The class names do not follow the correct pattern. WP_Privacy_Data_Export_Requests_Table, for example should be WP_Privacy_Data_Export_Requests_List_Table.

When a class is in its own file, the name should be class-actualclassname.php. In the current state, the file for WP_Privacy_Data_Export_Requests_Table would be class-wp-privacy-data-export-requests-table.php, which does not match the pattern _get_list_table() expects. Changing the class name is a backward compatibility issue, so it needs to be handled carefully.

Going to move this to 5.0 for visibility and because this is at a minimum blocked by #43895. Ideally, both of these tickets should land in 5.0.

[peterwilsoncc]

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

[pento]

Bumping to match #43895.

[garrett-eclipse]

Bumping to match #43895.

[azaozz]

I'm wondering how useful _get_list_table() is? Perhaps we should be deprecating it? :) (unless I'm missing something).

Sure, at the time it was making sense to "normalize" setting of $args['screen']. This can easily be done in the __construct() of each class. Are there any other benefits from it?

Now with class autoloading becoming possible, do we really need/want this kind of loading and "external" normalization?