Make WordPress Core

Opened 2 years ago

Last modified 11 months ago

#44845 assigned enhancement

_get_list_table: Support for privacy requests tables

Reported by: birgire Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: has-patch needs-refresh 2nd-opinion
Focuses: administration Cc:


The admin table classes are served with _get_list_table().

I wonder if we should add a support for the classes:

  • WP_Privacy_Data_Export_Requests_Table
  • WP_Privacy_Data_Removal_Requests_Table

in _get_list_table() for consistency.

Attachments (1)

44845.diff (3.4 KB) - added by birgire 2 years ago.

Download all attachments as: .zip

Change History (14)

2 years ago

#1 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9.9

#2 @desrosj
2 years ago

  • Milestone changed from 4.9.9 to 5.0

I like this idea, and the patch looks good. But, unfortunately, this is blocked by two issues.

First, _get_list_table() will try to include wp-admin/includes/class-wp-' . $required . '-list-table.php, which does not exist yet (see #43895).

Second, there is a problem with the privacy request class table names that will need to be resolved. The class names do not follow the correct pattern. WP_Privacy_Data_Export_Requests_Table, for example should be WP_Privacy_Data_Export_Requests_List_Table.

When a class is in its own file, the name should be class-actualclassname.php. In the current state, the file for WP_Privacy_Data_Export_Requests_Table would be class-wp-privacy-data-export-requests-table.php, which does not match the pattern _get_list_table() expects. Changing the class name is a backward compatibility issue, so it needs to be handled carefully.

Going to move this to 5.0 for visibility and because this is at a minimum blocked by #43895. Ideally, both of these tickets should land in 5.0.

#3 @peterwilsoncc
2 years ago

  • Milestone changed from 5.0 to 5.1

Moving to the 5.1 milestone due to the WordPress 5.0 focus on the new
editor (Gutenberg).

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.

2 years ago

#5 @pento
2 years ago

  • Milestone changed from 5.1 to 5.2

Bumping to match #43895.

#6 @desrosj
2 years ago

  • Owner set to desrosj
  • Status changed from new to assigned

#7 @garrett-eclipse
2 years ago

  • Keywords needs-refresh added

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.

2 years ago

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.

23 months ago

#10 @garrett-eclipse
23 months ago

  • Milestone changed from 5.2 to Future Release

Bumping to match #43895.

#11 @azaozz
20 months ago

I'm wondering how useful _get_list_table() is? Perhaps we should be deprecating it? :) (unless I'm missing something).

Sure, at the time it was making sense to "normalize" setting of $args['screen']. This can easily be done in the __construct() of each class. Are there any other benefits from it?

Now with class autoloading becoming possible, do we really need/want this kind of loading and "external" normalization?

#12 @garrett-eclipse
12 months ago

  • Component changed from Administration to Privacy
  • Focuses administration added; privacy removed
  • Keywords 2nd-opinion added

#13 @desrosj
11 months ago

  • Owner desrosj deleted
Note: See TracTickets for help on using tickets.