Opened 6 years ago
Closed 6 years ago
#45308 closed defect (bug) (fixed)
Use duplicate hook reference syntax for duplicates of 'link_category' and `pre_user_login`
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.1 | Priority: | normal |
| Severity: | minor | Version: | 2.2 |
| Component: | General | Keywords: | has-patch |
| Focuses: | docs | Cc: |
Description
link_category and pre_user_login appear to be the last remaining hooks that are defined in more than one place and still uniquely documented in each place. The convention for duplicated hooks is for one instance of the hook to be considered canonical with full documentation while all subsequent instances get documented with a special comment referencing that canonical documentation.
See attached patch for fix.
Related: the hook user_confirmed_action_email_content is also duplicated, but each instance's documentation differs in meaningful ways. See #44314 for discussion on the matter (particularly my pertinent comment).
Attachments (1)
Change History (8)
#1
@
6 years ago
- Milestone changed from Awaiting Review to 5.0.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#5
@
6 years ago
- Milestone changed from 5.0.3 to 5.1
Per today's bug scrub, documentation enhancements will be addressed in 5.1, coming next month.
Patch mentioned in ticket.