WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

#45399 closed defect (bug) (fixed)

Remove unsupported oEmbed providers

Reported by: notnownikki Owned by: desrosj
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description

FunnyOrDie and Photobucket have oEmbed endpoints listed in wp-includes/class-oembed.php that no longer exist.

Do we have anyone we can contact there to see if their APIs have been updated to a different location, or deprecated altogether?

I can easily do a patch to remove the providers if they have been deprecated.

Attachments (3)

45399.diff (2.9 KB) - added by skostadinov 6 months ago.
45399.2.diff (3.7 KB) - added by skostadinov 6 months ago.
45399.3.diff (3.3 KB) - added by desrosj 5 months ago.

Download all attachments as: .zip

Change History (10)

#1 @desrosj
6 months ago

  • Milestone changed from Awaiting Review to 5.1

@skostadinov
6 months ago

#2 @skostadinov
6 months ago

  • Keywords has-patch added

I removed the unsupported providers.

@skostadinov
6 months ago

#3 @SergeyBiryukov
6 months ago

  • Component changed from General to Embeds

This ticket was mentioned in Slack in #core-media by notnownikki. View the logs.


5 months ago

#5 @desrosj
5 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

@desrosj
5 months ago

#6 @desrosj
5 months ago

  • Keywords commit added

Thanks for this one, @notnownikki!

45399.2.diff was not applying correctly so I have refreshed it. I did some research but could not find any documentation of new locations. FunnyOrDie formed a new partnership with Vox Media in 2018. I am assuming that the oEmbed support was removed when that happened.

I also audited the other embed providers in the list and all of the remaining providers appear to still be supporting oEmbeds.

#7 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44552:

Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers.

These services no longer support oEmbed.

Props skostadinov, notnownikki.
Fixes #45399.

Note: See TracTickets for help on using tickets.