#45637 closed defect (bug) (fixed)
Update the WordPress packages for 5.0.2
Reported by: | youknowriad | Owned by: | youknowriad |
---|---|---|---|
Milestone: | 5.0.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch commit fixed-5.0 |
Focuses: | Cc: |
Description
For 5.0.2, we need to make sure we update the packages and use the ones shipped with the Gutenberg 4.7 release.
Attachments (2)
Change History (18)
This ticket was mentioned in Slack in #core-committers by youknowriad. View the logs.
6 years ago
#3
@
6 years ago
yes, most of the php changes here are automatically applied when you do npm install && grunt build
. And I did a git diff between 4.6.1 and 4.7 to ensure there's nothing we missed in the process.
#4
@
6 years ago
I tested it against 5.0 branch, everything works as expected. I also reviewed both PHP and JSON changes. All version bumps look correct.
I hope for 5.0.3 we:
- automate version bumps - we can build script which would do the trick for PHP files based on
package.json
changes introduced - integrate e2e testing to increase the confidence into changes being applied
It should be good to go.
#6
@
6 years ago
- Keywords fixed-5.0 added
- Resolution fixed deleted
- Status changed from closed to reopened
#8
@
6 years ago
- Keywords fixed-5.0 removed
@gziolo I tested the patch and it works well for me, I confirm the ACF blocks issue is fixed.
#9
@
6 years ago
- Keywords has-patch commit added
@gziolo, @youknowriad: Patch looks good, could one of you commit it, please? I'll start preparing for RC2.
The JavaScript changes look good to me. I assume the PHP changes are reflected from the Gutenberg repo.