Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#45637 closed defect (bug) (fixed)

Update the WordPress packages for 5.0.2

Reported by: youknowriad's profile youknowriad Owned by: youknowriad's profile youknowriad
Milestone: 5.0.2 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit fixed-5.0
Focuses: Cc:

Description

For 5.0.2, we need to make sure we update the packages and use the ones shipped with the Gutenberg 4.7 release.

Attachments (2)

packages-47-update.patch (26.9 KB) - added by youknowriad 6 years ago.
5-0-2.diff (8.0 KB) - added by gziolo 6 years ago.
Updated diff with changes for packages in state for 4.7.1 plugin release

Download all attachments as: .zip

Change History (18)

This ticket was mentioned in Slack in #core-committers by youknowriad. View the logs.


6 years ago

#2 @atimmer
6 years ago

The JavaScript changes look good to me. I assume the PHP changes are reflected from the Gutenberg repo.

#3 @youknowriad
6 years ago

yes, most of the php changes here are automatically applied when you do npm install && grunt build. And I did a git diff between 4.6.1 and 4.7 to ensure there's nothing we missed in the process.

#4 @gziolo
6 years ago

I tested it against 5.0 branch, everything works as expected. I also reviewed both PHP and JSON changes. All version bumps look correct.

I hope for 5.0.3 we:

  • automate version bumps - we can build script which would do the trick for PHP files based on package.json changes introduced
  • integrate e2e testing to increase the confidence into changes being applied

It should be good to go.

#5 @youknowriad
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44183:

Block Editor: Upgrade @wordpress packages to the latest version (4.7).

Updated packages:

  • @wordpress/annotations@1.0.4
  • @wordpress/api-fetch@2.2.6
  • @wordpress/block-library@2.2.10
  • @wordpress/block-serialization-default-parser@2.0.2
  • @wordpress/block-serialization-spec-parser@2.0.2
  • @wordpress/blocks@6.0.4
  • @wordpress/components@7.0.4
  • @wordpress/core-data@2.0.15
  • @wordpress/data@4.1.0
  • @wordpress/date@3.0.1
  • @wordpress/edit-post@3.1.5
  • @wordpress/editor@9.0.5
  • @wordpress/eslint-plugin@1.0.0
  • @wordpress/format-library@1.2.8
  • @wordpress/html-entities@2.0.4
  • @wordpress/list-reusable-blocks@1.1.17
  • @wordpress/notices@1.1.1
  • @wordpress/nux@3.0.5
  • @wordpress/rich-text@3.0.3
  • @wordpress/url@2.3.2
  • @wordpress/viewport@2.0.13

This also includes the updates the Core blocks.
The script loader is updated to match the Gutenberg repository too.

Props atimmer, gziolo, joen.
Fixes #45442, #45637.

#6 @youknowriad
6 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @SergeyBiryukov
6 years ago

#45442 was marked as a duplicate.

@gziolo
6 years ago

Updated diff with changes for packages in state for 4.7.1 plugin release

#8 @youknowriad
6 years ago

  • Keywords fixed-5.0 removed

@gziolo I tested the patch and it works well for me, I confirm the ACF blocks issue is fixed.

#9 @pento
6 years ago

  • Keywords has-patch commit added

@gziolo, @youknowriad: Patch looks good, could one of you commit it, please? I'll start preparing for RC2.

#10 @gziolo
6 years ago

On it.

#11 @gziolo
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44287:

Block Editor: Upgrade @WordPress packages to the latest version (4.7.1)

Updated packages:

  • @wordpress/block-library@2.2.11
  • @wordpress/edit-post@3.1.6
  • @wordpress/editor@9.0.6
  • @wordpress/format-library@1.2.9

Props youknowriad, pento.

Fixes #45637.

#12 @gziolo
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 @pento
6 years ago

  • Keywords fixed-5.0 added

#14 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44296:

Block Editor: Upgrade @wordpress packages to match version 4.7.1.

Updated packages:

  • `@wordpress/annotations
  • `@wordpress/api-fetch
  • `@wordpress/block-library@2.2.10
  • @wordpress/block-serialization-default-parser@2.0.2
  • @wordpress/block-serialization-spec-parser@2.0.2
  • @wordpress/blocks@6.0.4
  • @wordpress/components@7.0.4
  • @wordpress/core-data@2.0.15
  • @wordpress/data@4.1.0
  • @wordpress/date@3.0.1
  • @wordpress/edit-post@3.1.5
  • @wordpress/editor@9.0.5
  • @wordpress/eslint-plugin@1.0.0
  • @wordpress/format-library@1.2.8
  • @wordpress/html-entities@2.0.4
  • @wordpress/list-reusable-blocks@1.1.17
  • @wordpress/notices@1.1.1
  • @wordpress/nux@3.0.5
  • @wordpress/rich-text@3.0.3
  • @wordpress/url@2.3.2
  • @wordpress/viewport@2.0.13

This also includes the updates the Core blocks.

The script loader is updated to match the Gutenberg repository as well.

Props atimmer, gziolo, joen, youknowriad.

Merges [44183] to trunk.

Fixes #45442, #45637.

#15 @SergeyBiryukov
6 years ago

In 44319:

Block Editor: Upgrade @WordPress packages to the latest version (4.7.1)

Updated packages:

  • @wordpress/block-library@2.2.11
  • @wordpress/edit-post@3.1.6
  • @wordpress/editor@9.0.6
  • @wordpress/format-library@1.2.9

Props youknowriad, pento.
Merges [44287] to trunk.
Fixes #45637.

This ticket was mentioned in Slack in #core by aduth. View the logs.


6 years ago

Note: See TracTickets for help on using tickets.