Fix parameter name typo in 'taxonomy_meta_box_sanitize_cb_checkboxes'

[itowhid06]

Changed parameter $taxonmy to $taxonomy in 'taxonomy_meta_box_sanitize_cb_checkboxes'

[mukesh27]

Nice cache @itowhid06.

Do not understood why function used 2 arguments as $taxonmy is not used in function

<?php
function taxonomy_meta_box_sanitize_cb_checkboxes( $taxonmy, $terms ) {
    return array_map( 'intval', $terms );
}

If system not used $taxonmy then need to remove first argument from the function like below.

<?php
function taxonomy_meta_box_sanitize_cb_checkboxes( $terms ) {
    return array_map( 'intval', $terms );
}

[faisal03]

As per @mukesh27 's suggestion, the $taxonmy is not used in the function, which is removed in the https://core.trac.wordpress.org/attachment/ticket/45756/45756_2.diff patch

[itowhid06]

@mukesh27 @faisal03 , I don't think it's that simple! where this function is getting called, both arguments are being passed, If we want to remove the first argument, then those places should also be updated. Otherwise your proposed fix will create new issue by trying to fix a non-existent problem!

[faisal03]

@itowhid06 You are correct. I have checked the trunk and not able to find any calls for that function. Maybe I missed somewhere? Can you please look at your end too?

[itowhid06]

@faisal03 , taxonomy_meta_box_sanitize_cb_checkboxes has been used as a sanitization callback in class-wp-taxonomy.php - line 364. I've not got time to delve into that code yet, may be I'll give it a go when I get some time.

[SergeyBiryukov]

Replying to mukesh27:

Do not understood why function used 2 arguments as $taxonmy is not used in function

<?php
function taxonomy_meta_box_sanitize_cb_checkboxes( $taxonmy, $terms ) {
    return array_map( 'intval', $terms );
}

Both the $taxonomy and $terms arguments are passed to the callback in edit_post()​.

Even though taxonomy_meta_box_sanitize_cb_checkboxes() does not use the $taxonomy argument, we cannot remove it as the function signature needs to remain compatible with taxonomy_meta_box_sanitize_cb_input(), which does use the argument. Other (custom) callbacks might use it as well.

[SergeyBiryukov]

In 44367:

Taxonomy: Fix typo in taxonomy_meta_box_sanitize_cb_checkboxes() argument name.

Props itowhid06.
Fixes #45756.