Http Status Codes are too much generic

[astronati]

The status code should be used in the appropriate way.

​https://github.com/WordPress/WordPress/blob/6e3adbfe8ca720506ecdbe45c6c5571b545d3f60/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php#L431

The link above shows when the status code does not match the error. Here we should expect to see 409 and not 400

[TimothyBlynJacobs]

This was intentionally changed from a 409 in #42781.

[astronati]

@TimothyBlynJacobs I'm reading the change was done to match a "consistency". Is it clear that for any client that receives that error there is no way to understand the real problem?

What should client do when receive the 400? At this point it should try to perform a non deterministic number of calls trying to guess the real reason.

I don't see why that decision was made. Could you give us more information please? Thanks

[astronati]

@danielbachhuber The original ticket was approved by you.

Could you please read my comment? I would like to understand better the reason why you approved that case.
Thanks

[TimothyBlynJacobs]

Sure! The idea is to instead look at the code in the error response body. In this case term_exists.

{
  "code": "term_exists",
  "message": "A term with the name provided already exists in this taxonomy.",
  "data": {
    "status": 400,
    "term_id": 22
  }
}

[astronati]

Thanks @TimothyBlynJacobs

Is there a list where I can find all internal error codes?
Thanks

Replying to TimothyBlynJacobs:

Sure! The idea is to instead look at the code in the error response body. In this case term_exists.

{
  "code": "term_exists",
  "message": "A term with the name provided already exists in this taxonomy.",
  "data": {
    "status": 400,
    "term_id": 22
  }
}

[TimothyBlynJacobs]

I don't think that is documented. Best to look at the source code for the controllers.

[desrosj]

Removing Awaiting Review milestone from closed tickets.