#45986 closed defect (bug) (fixed)
Update the update-php URL and add annotation
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 5.1 |
Component: | Site Health | Keywords: | has-patch servehappy |
Focuses: | Cc: |
Description
Update previously committed instances of https://wordpress.org/support/update-php
to utilize the new wp_get_update_php_url()
introduced in r44476
Attachments (5)
Change History (13)
This ticket was mentioned in Slack in #core-php by afragen. View the logs.
6 years ago
@
6 years ago
changed function name to wp_update_php_annotation()
as it doesn't return a value so get
is incorrect
#3
@
6 years ago
- Summary changed from Update the update-php URL to Update the update-php URL and add annotation
#4
@
6 years ago
- Milestone changed from Awaiting Review to 5.1
Adding to 5.1 milestone for consideration.
#6
@
6 years ago
- Keywords dev-feedback removed
45986.5.diff enhances the previous patches in the following ways:
- Only show the information about updating PHP if
current_user_can( 'update_php' )
. This was missed in the original ticket. - In
wp-admin/includes/plugin-install.php
, ensure that callingwp_update_php_annotation()
does not cause invalid HTML markup with nestedp
tags. - In
wp-admin/includes/plugin-install.php
, get rid of the "so unfortunately you cannot install it" part of the message. This makes it consistent with the message about the WordPress version and prevents inaccuracies, as this information may also be displayed when the plugin is already installed.
Note: See
TracTickets for help on using
tickets.
Use wp_get_update_php_url()