#45686 closed enhancement (fixed)
Refine Update PHP core notice
Reported by: | flixos90 | Owned by: | flixos90 |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | servehappy has-patch ui-feedback has-dev-note |
Focuses: | Cc: |
Description
As clarified in recent weeks, the goal for the initial parts of the Servehappy core integrations is to be released as part of WordPress 5.1. For core, this encompasses both #44458 and refining the notice introduced via #41191 - the latter is covered by this ticket.
Tasks to take care of:
- Version numbers need to be updated to
5.1.0
. - The link URL to the Update PHP page needs to be updated to use the slug
update-php
, see https://wordpress.org/support/update-php/. - The link URL needs to be customizable via both an environment variable (preferably for hosting providers) and a filter (for runtime adjustment).
- In case the link URL is changed from the default one via one of the two mentioned ways, there should be an annotation indicating that this link is not officially endorsed by WordPress.
Attachments (4)
Change History (18)
This ticket was mentioned in Slack in #core-php by flixos90. View the logs.
6 years ago
This ticket was mentioned in Slack in #core-php by flixos90. View the logs.
6 years ago
#4
@
6 years ago
@flixos90 should I be updating the other relevant Servehappy tickets with the proposed wp_get_update_php_url()
?
#5
follow-up:
↓ 6
@
6 years ago
@afragen I suggest to wait until this is committed. You don't wanna do double work in case it gets changed again. :)
#6
in reply to:
↑ 5
@
6 years ago
Replying to flixos90:
@afragen I suggest to wait until this is committed. You don't wanna do double work in case it gets changed again. :)
True enough.
This ticket was mentioned in Slack in #core-php by flixos90. View the logs.
6 years ago
#9
@
6 years ago
45686.2.diff adds a note when the URL to the Update PHP has been adjusted (via environment variable or filter, as mentioned before). This note indicates that the URL is not provided by WordPress core itself. The original URL is also linked to as an additional resource.
A screenshot with that has been provided.
This ticket was mentioned in Slack in #core-php by flixos90. View the logs.
6 years ago
#13
@
6 years ago
- Keywords has-dev-note added
Dev note has been published: https://make.wordpress.org/core/2019/01/14/php-site-health-mechanisms-in-5-1/.
45686.diff introduces a function to retrieve the Update PHP URL, which includes support for a
WP_UPDATE_PHP_URL
environment variable and also runs the result through awp_update_php_url
filter. The patch furthermore adjusts version numbers and accounts for the slug change of the default URL.@pento Could you clarify what the requirements are for an annotation as mentioned, which would clarify that the custom URL, if provided, is not endorsed by WordPress? We could use some help by someone with the legal background for this. Furthermore, we would need design guidance of how to incorporate this message in the UI.
For reference, I provided a current screenshot.