Argument types mismatch

[subrataemfluence]

A lot of areas of wp-inclues/comment-template.php arguments types described in function Doc-blocks are reported mismatched with that of actual arguments in function declaration.

I searched Trac repo and unable to find a ticket specific to this.

[mukesh27]

Updated Patch. Change some docs and change false placement as per other docs.

[earnjam]

Clearing the version since this isn't specific to 5.0.3 and these docblocks apply to functions added at different times.

Also just a suggestion to each of you @mukesh27 and @subrataemfluence. When you make your patches, you should generate them from the root, so it would include src/ in the path of the file(s) being edited.

[subrataemfluence]

Thank you @earnjam . I will follow this in my future patches.

Replying to earnjam:

Clearing the version since this isn't specific to 5.0.3 and these docblocks apply to functions added at different times.

Also just a suggestion to each of you @mukesh27 and @subrataemfluence. When you make your patches, you should generate them from the root, so it would include src/ in the path of the file(s) being edited.

[mukesh27]

@earnjam Thanks for your guidance. Will follow it in future patches.

Replying to earnjam:

Clearing the version since this isn't specific to 5.0.3 and these docblocks apply to functions added at different times.

Also just a suggestion to each of you @mukesh27 and @subrataemfluence. When you make your patches, you should generate them from the root, so it would include src/ in the path of the file(s) being edited.

[davidbaumwald]

Looks like this is a duplicate of #46931. Closing this one in favor of that, as the work there has a bit more coverage.