WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#46220 closed defect (bug) (fixed)

Failed to set custom WordPress Database Table prefix during 1st fresh install in 5.1-RC1

Reported by: Luciano Croce Owned by: luciano-croce
Milestone: 5.1 Priority: normal
Severity: critical Version: 5.1
Component: Upgrade/Install Keywords: has-patch dev-reviewed commit
Focuses: Cc:

Description

During 1st fresh install of WordPress Version 5.1-RC1 setup failed to create "Custom Database Table Prefix" and leave default wp-config-sample-php value.

For example: instead of custom "wp_51_" setup set default "wp_"

I have tested this issue in "build trunk" pre RC1 44567, RC1 44568, post RC1 44569, and also in the latest "core trunk" 44737

Attachments (1)

46220.patch (525 bytes) - added by ocean90 2 months ago.

Download all attachments as: .zip

Change History (8)

#1 @desrosj
2 months ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 5.1

@ocean90
2 months ago

#2 @ocean90
2 months ago

  • Keywords has-patch added; needs-testing dev-feedback removed

Since [42343] the sample config file no longer uses two spaces between the variable name and the assignment operator. The check in the setup script was updated in [43650] but still incomplete since the string is now one char shorter.

#3 @Luciano Croce
2 months ago

Patch tested: works for me. Thanks!

#4 @pento
2 months ago

  • Keywords dev-reviewed added

46220.patch looks good to me.

#5 @pento
2 months ago

  • Keywords commit added

#6 @ocean90
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44738:

Upgrade/Install: Update character count for the $table_prefix config line after [43650] and [42343].

Fixes #46220.

This ticket was mentioned in Slack in #polyglots by wolly. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.