WordPress.org

Make WordPress Core

Opened 18 months ago

Last modified 10 months ago

#46328 reviewing defect (bug)

Long spam link mobile view

Reported by: Marius84 Owned by: SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: minor Version: 3.9
Component: Comments Keywords: good-first-bug has-patch needs-testing
Focuses: ui Cc:

Description

I got some spam comments with long link. When I access admin dashboard trough mobile phone and go to the spam comment section the text "Item" cover "Empty Trash" text.

Screenshot: https://prnt.sc/mp1m7i

Attachments (4)

IMG_5298.PNG (295.4 KB) - added by Marius84 18 months ago.
common.css.patch (338 bytes) - added by sharaz 14 months ago.
46328.diff (364 bytes) - added by donmhico 12 months ago.
Update the common.css.patch.
46328.1.diff (639 bytes) - added by donmhico 12 months ago.
Fix overflowing long link and overlapping comment count in Empty Trash button issue.

Download all attachments as: .zip

Change History (18)

@Marius84
18 months ago

#1 @earnjam
14 months ago

  • Focuses ui added
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 5.1 to 3.9

Thanks @Marius84! I am able to replicate this.

It looks like it's due to this rule on line 1900 in /wp-admin/css/list-tables.css

.widefat * {
        word-wrap: normal;
}

It overrides the default break-word value for .widefat * in the common css file, but I'm not sure why specifically. I'd be a bit weary of changing that for how many things it would affect. Might be better to target the comments list table directly, or even the specific paragraph tag where these things are overrunning the container.

@sharaz
14 months ago

#2 @sharaz
14 months ago

  • Keywords has-patch added; needs-patch removed
  • Resolution set to invalid
  • Status changed from new to closed

#3 @sharaz
14 months ago

  • Keywords has-unit-tests dev-feedback added
  • Resolution invalid deleted
  • Status changed from closed to reopened

#4 @earnjam
14 months ago

  • Keywords needs-testing added; has-unit-tests removed

This ticket was mentioned in Slack in #core by sharaz. View the logs.


14 months ago

#6 @SergeyBiryukov
14 months ago

  • Milestone changed from Future Release to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from reopened to reviewing

#7 @SergeyBiryukov
12 months ago

  • Keywords needs-patch added; has-patch dev-feedback needs-testing removed

In my testing, the overlapping of "Empty Trash" and "1 item" happens regardless of the long URL. Looks like absolute positioning is not ideal for smaller screens like this.

common.css.patch fixes the URL wrapping, but not the overlapping.

#8 @donmhico
12 months ago

common.css.patch doesn't work for me. See my screenshot - https://prnt.sc/opdcvf

@donmhico
12 months ago

Update the common.css.patch.

@donmhico
12 months ago

Fix overflowing long link and overlapping comment count in Empty Trash button issue.

#9 @donmhico
12 months ago

  • Keywords has-patch added; needs-patch removed

#10 @davidbaumwald
10 months ago

@SergeyBiryukov Are you still up for including this one in 5.3?

This ticket was mentioned in Slack in #core by marybaum. View the logs.


10 months ago

#12 @davidbaumwald
10 months ago

  • Keywords commit added

This one was brought up in today's scrub. This looks like a good candidate for 5.3, so marking for commit.

#13 @marybaum
10 months ago

  • Keywords needs-testing added

#14 @davidbaumwald
10 months ago

  • Keywords commit removed
  • Milestone changed from 5.3 to Future Release

With 5.3 RC1 releasing today, this ticket is being moved to Future Release. If any committer feels this can be worked in to 5.3 before the deadline or can assume ownership in the 5.4 cycle, feel free to move it back up.

Note: See TracTickets for help on using tickets.