WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#46368 closed defect (bug) (fixed)

Drop background on #menu-management on Admin Menus screen

Reported by: garrett-eclipse Owned by: audrasjb
Milestone: 5.1.1 Priority: normal
Severity: normal Version: 5.1
Component: Menus Keywords: has-patch commit has-screenshots
Focuses: ui Cc:

Description

Hello,

Minor, but I found this style caused the Menus screen to display a little odd as the 'Menu Structure' heading seems to run up against this contrast.
nav-menus.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus.css#L164
& in nav-menus-rtl.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164

Can it just be removed to clean up the interface.

Thank you

Attachments (6)

Screen Shot 2019-02-27 at 10.30.51 PM.png (184.2 KB) - added by garrett-eclipse 5 months ago.
w/ background on #menu-management
Screen Shot 2019-02-27 at 10.31.02 PM.png (180.5 KB) - added by garrett-eclipse 5 months ago.
w/o background on #menu-management
46368.diff (328 bytes) - added by mukesh27 5 months ago.
Patch.
46368-bg.png (80.3 KB) - added by afercia 5 months ago.
Screenshot to clarify where the background color is actually applied
46368.1.diff (497 bytes) - added by audrasjb 5 months ago.
Moving background color to header/footer only
46368.1-bg.png (49.4 KB) - added by mukesh27 5 months ago.

Download all attachments as: .zip

Change History (24)

@garrett-eclipse
5 months ago

w/ background on #menu-management

@garrett-eclipse
5 months ago

w/o background on #menu-management

@mukesh27
5 months ago

Patch.

#1 @mukesh27
5 months ago

  • Focuses ui added
  • Keywords ui-feedback added

Nice cache @garrett-eclipse

#2 @mukesh27
5 months ago

  • Keywords needs-patch added

#3 @mukesh27
5 months ago

  • Keywords has-patch added; needs-patch removed

#4 @garrett-eclipse
5 months ago

  • Keywords needs-refresh added; has-patch removed

Thanks @mukesh27 I appreciate the patch. Don't forget to also update the RTL version here;
nav-menus-rtl.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164

Cheers

#5 @ocean90
5 months ago

  • Keywords has-patch added; needs-refresh removed
  • Milestone changed from Awaiting Review to 5.2

@garrett-eclipse RTL files are generated by the build process. Only files in https://github.com/WordPress/wordpress-develop need to be changed.

#6 @garrett-eclipse
5 months ago

Thanks @ocean90 I appreciate the pointer, and sorry @mukesh27 for that.

#7 @afercia
5 months ago

Thanks, good catch! I believe the background issue has been introduced in [42857] when I moved the "Menu Structure" heading above the box. So it's a minor regression in 5.1 and seems simple enough to be fixed in 5.1.1.

However, the background actually sets a background color to #nav-menu-header and #nav-menu-footer so it needs to be restored on those 2 elements. In the stylesheet, these elements are already selected, I'd try to add the background there:

#nav-menu-header,
#nav-menu-footer {
	padding: 0 10px;
}

@afercia
5 months ago

Screenshot to clarify where the background color is actually applied

#8 @afercia
5 months ago

  • Keywords needs-refresh added
  • Milestone changed from 5.2 to 5.1.1
  • Type changed from enhancement to defect (bug)
  • Version set to 5.1

Moving to 5.1.1 consideration, as it's a (minor) regression.

This ticket was mentioned in Slack in #core by timothybjacobs. View the logs.


5 months ago

This ticket was mentioned in Slack in #core by lukecarbis. View the logs.


5 months ago

#11 @audrasjb
5 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

@audrasjb
5 months ago

Moving background color to header/footer only

#12 @audrasjb
5 months ago

  • Keywords commit added; ui-feedback needs-refresh removed

Thanks for the review @afercia
46368.1.diff moves the background color to header/footer rules.

#13 @audrasjb
5 months ago

  • Status changed from reviewing to accepted

#14 @mukesh27
5 months ago

@audrasjb, Patch 46368.1.diff is working fine for me.

@mukesh27
5 months ago

#15 @audrasjb
5 months ago

  • Keywords has-screenshots added

This ticket was mentioned in Slack in #core by pbiron. View the logs.


5 months ago

#17 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 44801:

Menus: After [42857], apply background to the correct elements on Menus screen.

Props audrasjb, afercia, mukesh27, garrett-eclipse.
Fixes #46368.

#18 @SergeyBiryukov
4 months ago

In 44802:

Menus: After [42857], apply background to the correct elements on Menus screen.

Props audrasjb, afercia, mukesh27, garrett-eclipse.
Merges [44801] to the 5.1 branch.
Fixes #46368.

Note: See TracTickets for help on using tickets.