Drop background on #menu-management on Admin Menus screen

[garrett-eclipse]

Hello,

Minor, but I found this style caused the Menus screen to display a little odd as the 'Menu Structure' heading seems to run up against this contrast.
nav-menus.css - ​https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus.css#L164
& in nav-menus-rtl.css - ​https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164

Can it just be removed to clean up the interface.

Thank you

[garrett-eclipse]

w/ background on #menu-management

[garrett-eclipse]

w/o background on #menu-management

[mukesh27]

Patch.

[mukesh27]

Nice cache @garrett-eclipse

[garrett-eclipse]

Thanks @mukesh27 I appreciate the patch. Don't forget to also update the RTL version here;
nav-menus-rtl.css - ​https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164

Cheers

[ocean90]

@garrett-eclipse RTL files are generated by the build process. Only files in ​https://github.com/WordPress/wordpress-develop need to be changed.

[garrett-eclipse]

Thanks @ocean90 I appreciate the pointer, and sorry @mukesh27 for that.

[afercia]

Thanks, good catch! I believe the background issue has been introduced in [42857] when I moved the "Menu Structure" heading above the box. So it's a minor regression in 5.1 and seems simple enough to be fixed in 5.1.1.

However, the background actually sets a background color to #nav-menu-header and #nav-menu-footer so it needs to be restored on those 2 elements. In the stylesheet, these elements are already selected, I'd try to add the background there:

#nav-menu-header,
#nav-menu-footer {
	padding: 0 10px;
}

[afercia]

Screenshot to clarify where the background color is actually applied

[afercia]

Moving to 5.1.1 consideration, as it's a (minor) regression.

[audrasjb]

Moving background color to header/footer only

[audrasjb]

Thanks for the review @afercia
46368.1.diff moves the background color to header/footer rules.

[mukesh27]

@audrasjb, Patch 46368.1.diff is working fine for me.

[SergeyBiryukov]

In 44801:

Menus: After [42857], apply background to the correct elements on Menus screen.

Props audrasjb, afercia, mukesh27, garrett-eclipse.
Fixes #46368.

[SergeyBiryukov]

In 44802:

Menus: After [42857], apply background to the correct elements on Menus screen.

Props audrasjb, afercia, mukesh27, garrett-eclipse.
Merges [44801] to the 5.1 branch.
Fixes #46368.