#46368 closed defect (bug) (fixed)
Drop background on #menu-management on Admin Menus screen
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.1.1 | Priority: | normal |
Severity: | normal | Version: | 5.1 |
Component: | Menus | Keywords: | has-patch commit has-screenshots |
Focuses: | ui | Cc: |
Description
Hello,
Minor, but I found this style caused the Menus screen to display a little odd as the 'Menu Structure' heading seems to run up against this contrast.
nav-menus.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus.css#L164
& in nav-menus-rtl.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164
Can it just be removed to clean up the interface.
Thank you
Attachments (6)
Change History (24)
#4
@
6 years ago
- Keywords needs-refresh added; has-patch removed
Thanks @mukesh27 I appreciate the patch. Don't forget to also update the RTL version here;
nav-menus-rtl.css - https://github.com/WordPress/WordPress/blob/173e0f9ee7b7f7dee03c351f2f9bf968759eb20e/wp-admin/css/nav-menus-rtl.css#L164
Cheers
#5
@
6 years ago
- Keywords has-patch added; needs-refresh removed
- Milestone changed from Awaiting Review to 5.2
@garrett-eclipse RTL files are generated by the build process. Only files in https://github.com/WordPress/wordpress-develop need to be changed.
#7
@
6 years ago
Thanks, good catch! I believe the background issue has been introduced in [42857] when I moved the "Menu Structure" heading above the box. So it's a minor regression in 5.1 and seems simple enough to be fixed in 5.1.1.
However, the background actually sets a background color to #nav-menu-header
and #nav-menu-footer
so it needs to be restored on those 2 elements. In the stylesheet, these elements are already selected, I'd try to add the background there:
#nav-menu-header, #nav-menu-footer { padding: 0 10px; }
#8
@
6 years ago
- Keywords needs-refresh added
- Milestone changed from 5.2 to 5.1.1
- Type changed from enhancement to defect (bug)
- Version set to 5.1
Moving to 5.1.1 consideration, as it's a (minor) regression.
This ticket was mentioned in Slack in #core by timothybjacobs. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by lukecarbis. View the logs.
6 years ago
#12
@
6 years ago
- Keywords commit added; ui-feedback needs-refresh removed
Thanks for the review @afercia
46368.1.diff moves the background color to header/footer rules.
#14
@
6 years ago
@audrasjb, Patch 46368.1.diff is working fine for me.
w/ background on #menu-management