Context Navigation

#46627 closed defect (bug) (fixed)

Reported by:	pbearne	Owned by:	SergeyBiryukov
Milestone:	5.3	Priority:	low
Severity:	normal	Version:
Component:	Date/Time	Keywords:	has-unit-tests dev-feedback has-patch
Focuses:		Cc:

The is_new_day() function uses != to test I see no reason why we can't change this too !==

So I have added a patch to do this and Unit test to check it

46627.patch (1.4 KB) - added by pbearne 7 years ago.: patch with unit test
46627-just-unit-unit-no-fix.patch (1.0 KB) - added by pbearne 7 years ago.: patch for the unfixed function just unitn test
46627-just-unit-unit-no-fix.2.patch (1021 bytes) - added by pbearne 7 years ago.: fixed version of patch
46627.2.patch (1.4 KB) - added by pbearne 7 years ago.: fixed version of patch

Download all attachments as: .zip

patch with unit test

patch for the unfixed function just unitn test

If it, not felt that we should "fix" the function I have attached a unit test for the current code

part of my ongoing project to add unit tests for all function in functions.php :-)

Description modified (diff)
Priority changed from normal to low
Summary changed from is_new_day uses a week compare to is_new_day uses a weak comparison