Twenty Fourteen: Long non-breaking text strings can cause horizontal scrolling

[ianbelanger]

While fixing #36346 I noticed that all Bundled Themes have some sort of word-wrap issues when using long non-breaking text strings. While this might be an edge case issue, I believe that it warrants fixing. Also, there doesn't seem to be any backwards compatibility issues.

In order to better track this issue in each theme, I am separating #36346 into separate tickets per theme.

[ianbelanger]

Fixes word-wrap issues

[ianbelanger]

46696.diff adds

-webkit-hyphens: auto;
-moz-hyphens: auto;
hyphens: auto;
word-wrap: break-word;

to these selectors:

.site-description,
.entry-title,
.comments-title

to prevent horizontal scrolling when long non-breaking text strings are used.

However, hyphens: auto; currently only works in Firefox. Unfortunately nothing worked for me in Chrome, IE11 or Edge.

This patch was tested on a Windows 10 machine, in Firefox, Chrome, IE11 and Edge browsers

Testing in other OS's and browsers would be appreciated.

[ianbelanger]

.site-description before in chrome

[ianbelanger]

.site-description after in chrome

[ianbelanger]

.entry-title before in Chrome

[ianbelanger]

.entry-title after in Chrome

[ianbelanger]

.comments-title before in Chrome

[ianbelanger]

.comments-title after in Chrome

[JeffPaul]

Per input in today's bugscrub, @dswebsme looking to test this on a Mac and update later today.

[dswebsme]

Patch looks good on Mac.

Tested in Chrome, Safari and Firefox.

Tested Site Title, Site Description, Post Title, Page Title, Content and Comments with non-breaking strings.

Mac results reflect AFTER screenshots captured by @ianbelanger.

[ianbelanger]

Thanks for testing @dswebsme.

I'm marking this for commit

[SergeyBiryukov]

Just wanted to note that there are some previous discussions on long non-breaking text strings in bundled themes: #25008, #25232, #29971, all closed as wontfix due to being an edge case. Should we revisit those discussions before making a decision on commit here?

[laurelfulford]

I added a comment to #36346 re: the previous tickets closed as wontfix -- it seemed like it'd be easiest to centralize that discussion in one spot. Any feedback/thoughts would be appreciated there!

[laurelfulford]

Thanks for tackling this @ianbelanger! I figured I could check these over while this issue is discussed in #36346 :)

46696.diff​ ​ looks good to me! Similar to my comment in #46704, what do you think about adding the -ms- prefix to hyphens as well, for Edge and IE 10-11? Like Twenty Fifteen, it looks like Twenty Fourteen already uses it in its existing hyphen styles.

I also noticed the theme also formats prefixes like:

-webkit-hyphens: auto;
-moz-hyphens:    auto;
-ms-hyphens:     auto;
hyphens:         auto;

... with extra spacing to line up the values. What do you think about following that, too, for consistency with existing styles?

[ianbelanger]

As per the discussion in #36346, I am closing this as a wontfix

See comment for details https://core.trac.wordpress.org/ticket/36346#comment:40