WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#46717 closed defect (bug) (fixed)

Site Health: show admin notice when JavaScript support is off

Reported by: afercia's profile afercia Owned by: afercia's profile afercia
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-screenshots site-health has-patch
Focuses: Cc:

Description

As done for all the admin pages that have features that depend on JavaScript support, also the Site Health pages should display an admin notice when JavaScript id disabled.

Also, the pages should probably display no content other than the admin notice. Examples:

Gutenberg:

http://cldup.com/cYBwIolQzT.png

Theme installer:

http://cldup.com/eH6sOsfEIV.png

Current Site Health status page:

http://cldup.com/S94us0qIfB.png

Attachments (2)

46717.diff​ (11.8 KB) - added by afercia 6 years ago.
46717.2.diff​ (11.8 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
6 years ago

#1 @afercia
6 years ago

  • Keywords has-patch added; needs-patch removed

46717.diff​

  • displays an error notice when JavaScript is off, consistently with other JavaScript-dependent screens
  • keeps the main h1 visible

Minor clean-ups:

  • makes code indentation consistent in site-health.php and site-health-info.php
  • removes a couple of <div class="wp-clearfix"></div> as that's not the intended usage of wp-clearfix (those divs didn't do anything anyways)

Screenshot:

http://cldup.com/HnlE_-wjml.png

#2 @afercia
6 years ago

  • Keywords needs-design-feedback removed
  • Owner set to afercia
  • Status changed from new to assigned

I guess there's no need for design feedback, as this is pretty standard in core.

@afercia
6 years ago

#3 @afercia
6 years ago

46717.2.diff​ updates the notice wording to The Site Health check requires JavaScript.

#4 @afercia
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45076:

Administration: Display a notice in the Site Health pages when JavaScript is off.

  • displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
  • keeps the main h1 visible

Minor clean-ups:

  • makes code indentation consistent in site-health.php and site-health-info.php
  • removes a couple of <div class="wp-clearfix"></div> as that's not the intended usage of wp-clearfix (those divs didn't do anything anyways)

Fixes #46717.

#5 @spacedmonkey
6 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.