WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 weeks ago

#46758 closed defect (bug) (fixed)

Media Trash: Primary button(s) should be on the left

Reported by: garrett-eclipse Owned by: afercia
Milestone: 5.2.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots fixed-major needs-testing
Focuses: ui, accessibility, administration Cc:

Description

Following the #design chat it was flagged that the Media Trash primary button(s) shouldn't be on the right;
https://wordpress.slack.com/archives/C02S78ZAL/p1554138401066300

Quoting @afercia;

Also: why primary buttons are on the right? :)

This came from the design discussion surrounding #44675 and is related to #46757 which denotes there should only be one primary button.

Attachments (1)

2019-04-01 at 18.01.jpg (18.5 KB) - added by garrett-eclipse 6 months ago.
Bulk Media Trash Select showing primary buttons on the right, should be on the left

Download all attachments as: .zip

Change History (13)

@garrett-eclipse
6 months ago

Bulk Media Trash Select showing primary buttons on the right, should be on the left

#1 @garrett-eclipse
6 months ago

  • Focuses accessibility added

#2 @ianbelanger
6 months ago

  • Keywords has-screenshots added

I'm not sure that we can move the buttons around yet, at least until #46757 is resolved. Mainly because we don't know which button will be the primary

#3 @garrett-eclipse
6 months ago

  • Keywords needs-design-feedback added

Thanks @ianbelanger I agree with you there. That being said with what info we have now I would suggest the following order;
Restore from Trash | Delete Permanently | Cancel
*And in #46757 I suggested the Delete get a new button class to mark it important as it's potentially irreversible.

Flagging for design review as well in hopes both tickets end up in the same scrub discussion.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


5 months ago

#5 @afercia
5 months ago

  • Milestone changed from Awaiting Review to Future Release

Moving to Future Release, pending resolution of #46757.

#6 @afercia
3 months ago

  • Milestone changed from Future Release to 5.3
  • Owner set to afercia
  • Status changed from new to assigned

As in this release cycle there's some focus on improvements for the media views, due also to the WPCampus accessibility report, I'd like to propose this ticket for 5.3 consideration together with #46757.

#7 @afercia
3 months ago

Note: a patch that fixes this issue is uploaded to #46757.

#8 @karmatosed
7 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45701:

Media: Reduces the bulk media options to have one primary button

This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov
Fixes #46757, #46758

#9 @joemcgill
5 weeks ago

  • Keywords fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


5 weeks ago

#11 @JeffPaul
4 weeks ago

  • Keywords needs-testing added; needs-design-feedback removed

This also needs testing to validate if this ticket is good to land in 5.2.3.

#12 @SergeyBiryukov
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45841:

Media: Reduces the bulk media options to have one primary button.

This fixes where 2 primary buttons were showing for bulk actions within media trash.

Props garrett-eclipse, afercia, ianbelanger, SergeyBiryukov, karmatosed.
Merges [45701] to the 5.2 branch.
Fixes #46757, #46758

Note: See TracTickets for help on using tickets.