Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46783 closed defect (bug) (fixed)

Site Health: Notice: Undefined property: WP_Site_Health::$mariadb in /wp-admin/includes/class-wp-site-health.php

Reported by: birgire's profile birgire Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health good-first-bug has-patch
Focuses: Cc:

Description

When viewing /wp-admin/site-health.php from trunk, I get:

Notice: Undefined property: WP_Site_Health::$mariadb in /wp-admin/includes/class-wp-site-health.php

Here

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-site-health.php#L931

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-site-health.php#L947

https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-site-health.php#L961

we have

( $this->mariadb ? 'MariaDB' : 'MySQL' ),

But it should be:

( $this->is_mariadb ? 'MariaDB' : 'MySQL' ),

Maybe this is already fixed, but I couldn't find it after a quick search here on Trac.

Attachments (1)

46783.diff (1.2 KB) - added by mukesh27 5 years ago.
Patch.

Download all attachments as: .zip

Change History (6)

#1 @birgire
5 years ago

  • Component changed from General to Administration

@mukesh27
5 years ago

Patch.

#2 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed

#3 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.2

#4 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45107:

Site Health: Use correct property for database-related messages.

Props mukesh27, birgire.
Fixes #46783.

#5 @spacedmonkey
5 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.