When menu item removed form Customizer menu uncheck it's source item

[garrett-eclipse]

Hello,

When using the Customizer menu the menu items that you add get checked off on the original panel. But when you remove those pages from the menu those items stay checked which can mislead users to think their page is still in the menu. It would be nice if once the last page for the item is removed from the menu it's relevant source menu item be unchecked.

Sorry I hope that wasn't confusing adding a screenshot.

[garrett-eclipse]

Added page is checked off

[garrett-eclipse]

Removed page leaves item checked off which is misleading and gives it almost a disabled state

[audrasjb]

Hi and thanks for the ticket @garrett-eclipse

I can reproduce the issue on my side. Moving this one to the next release.

[donmhico]

@garrett-eclipse @audrasjb - If you have time, can you test and review my attached patch 46830.diff.

Thanks.

[garrett-eclipse]

Successful testing demonstration showing checks revert to + plus icons when all items removed.

[garrett-eclipse]

Thanks @donmhico this worked really nicely, testing both Posts and Pages the check indicator reverts to the + add icon once all items are removed as desired.

Reviewing the code everything looked very well written thank you. In php unit tests I've seen ticket references as @ticket XXXXX but I'm not sure if that's also the standard with JS (referring to your @see reference).

@audrasjb would you mind taking a final review this works nicely and applies cleanly. I feel it's ready to commit but Customizer is your component ;)

P.S. While testing I found the check icon is lost if you click 'Add Items' to open/close the drawer. I've opened 47990 to look into keeping that check mark persistent.

[donmhico]

Thanks @garrett-eclipse. Maybe i'll use @link instead.

@see: A function or class relied on.
@link: URL that provides more information.

​https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

[donmhico]

Changed @see to @link.

[garrett-eclipse]

Nice, good call thanks @donmhico

[garrett-eclipse]

Thanks again for the patch on this @donmhico it's still applying cleanly and manual tests are all working nicely.

@audrasjb can you give the patch a final review, I feel it's ready for commit but would prefer a maintainer to move it forward.

Cheers

[audrasjb]

Works fine

[audrasjb]

Hi @garrett-eclipse,

The last patch applies cleanly and it works fine on my side after few local tests.
Looks good to go on my side.

[audrasjb]

Hi,
This ticket should have been committed before Beta 3 to ship with WP 5.3.
Moving it to milestone 5.4 as it's pretty close to a solution.

[garrett-eclipse]

Testing this on trunk it's working nicely @audrasjb can you test and rebless the ticket.

[SergeyBiryukov]

In 47356:

Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.

Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.