WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 6 weeks ago

#47990 new enhancement

Opening/Closing the 'Add Items' slideout in the Customizer Menu editor loses the check icon

Reported by: garrett-eclipse Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.3
Component: Customize Keywords: has-screenshots needs-patch
Focuses: javascript Cc:
PR Number:

Description

Hello,

While testing 46830 I came across a separate issue I'll open here. The checkbox to indicate an item (page/post) is in the menu gets reverted to the + add icon if you click 'All Items' button to open and close the select menu item drawer.

It would be nice if the checkbox icon was persistent to continue to indicate to the user what items are selected in the menu.

Thank you

Attachments (1)

a3e1043eba454d00c8fda6d539f02208.gif (555.9 KB) - added by garrett-eclipse 2 months ago.
Gif to illustrate the lose of state on menu items with the check reverting to the plus icon when the 'Add Items' drawer is open/closed.

Download all attachments as: .zip

Change History (7)

@garrett-eclipse
2 months ago

Gif to illustrate the lose of state on menu items with the check reverting to the plus icon when the 'Add Items' drawer is open/closed.

#1 @garrett-eclipse
2 months ago

  • Keywords has-screenshots added

#2 @dlh
2 months ago

Hey @garrett-eclipse,

Could you elaborate a bit on the preferred behavior? Is the suggestion to keep the items checked for as long as the Customizer is open? As long as the current changeset is unpublished (and therefore, potentially, across Customizer sessions)? Something else?

#3 @garrett-eclipse
2 months ago

Hi @dlh in my opinion I feel it would be beneficial when the 'Add Items' panel is opened it does a check on what's in the current menu and sets the checkmarks for all those items. In that way it doesn't matter if it's the first time opening customizer or if you're in the middle of working with it those checks would always indicate what's currently included in the menu. It could possibly just be tied to the open action on 'Add Items' and run the check then that way it's there on first open as well as if you close and reopen it.

I hope that clarifies,
Thank you
P.S. #46830 is related in that it affects those checks when no more items remain in the menu.

#4 @dlh
2 months ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version set to 4.3

Thanks @garrett-eclipse! To my ears this sounds closer to enhancement than bug, but I'll leave that call to you.

#5 @garrett-eclipse
2 months ago

  • Type changed from defect (bug) to enhancement

Thanks @dlh I'm fine with it being addressed as an enhancement, I appreciate your review.

#6 @garrett-eclipse
6 weeks ago

As I've been playing with Twenty Twenty I found another instance it would be nice to have the check applied is when Starter Content is loaded. In that case items can already be in the menu so would be good that on load they get checked.

Note: See TracTickets for help on using tickets.