Provide update-php link on WordPress update failure screen

[Hareesh Pillai]

When WordPress update fails due to an incompatible PHP version, the error message can be improved by displaying a link to the ​Update PHP page.

[netweb]

The screenshot above is from one of my sites not yet running PHP > 5.6

Here's the text for copy/paste purposes:

You cannot update because WordPress 5.2 requires PHP version 5.6.20 or higher. You are running version 5.5.9-1ubuntu4.27.

This localised version contains both the translation and various other localisation fixes. You can skip upgrading if you want to keep your current translation.

You cannot update because WordPress 5.2 requires PHP version 5.6.20 or higher. You are running version 5.5.9-1ubuntu4.27.

While your site is being updated, it will be in maintenance mode. As soon as your updates are complete, your site will return to normal.

The notice is displayed twice I believe because I'm running an #en-au localized install.

Lets include a link to ​https://wordpress.org/support/update-php/ in that notice so that users can access a resource to help guide them to upgrading PHP so that they can upgrade WP

---

For a start a quick look reveals the helper wp_get_update_php_url() function, using that to create a patch to include the localised URL for each of the PHP upgrade messages in:

src/wp-admin/install.php
248:    $compat = sprintf( __( 'You cannot install because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher and MySQL version %4$s or higher. You are running PHP version %5$s and MySQL version %6$s.' ), $version_url, $wp_version, $required_php_version, $required_mysql_version, $php_version, $mysql_version );
251:    $compat = sprintf( __( 'You cannot install because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You are running version %4$s.' ), $version_url, $wp_version, $required_php_version, $php_version );

src/wp-admin/update-core.php
81:                             $message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher and MySQL version %4$s or higher. You are running PHP version %5$s and MySQL version %6$s.' ), $version_url, $update->current, $update->php_version, $update->mysql_version, $php_version, $mysql_version );
84:                             $message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You are running version %4$s.' ), $version_url, $update->current, $update->php_version, $php_version );

src/wp-admin/upgrade.php
90:             $message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher and MySQL version %4$s or higher. You are running PHP version %5$s and MySQL version %6$s.' ), $version_url, $wp_version, $required_php_version, $required_mysql_version, $php_version, $mysql_version );
93:             $message = sprintf( __( 'You cannot update because <a href="%1$s">WordPress %2$s</a> requires PHP version %3$s or higher. You are running version %4$s.' ), $version_url, $wp_version, $required_php_version, $php_version );

src/wp-admin/includes/update-core.php
950:            return new WP_Error( 'php_mysql_not_compatible', sprintf( __( 'The update cannot be installed because WordPress %1$s requires PHP version %2$s or higher and MySQL version %3$s or higher. You are running PHP version %4$s and MySQL version %5$s.' ), $wp_version, $required_php_version, $required_mysql_version, $php_version, $mysql_version ) );
952:            return new WP_Error( 'php_not_compatible', sprintf( __( 'The update cannot be installed because WordPress %1$s requires PHP version %2$s or higher. You are running version %3$s.' ), $wp_version, $required_php_version, $php_version ) );

[afragen]

includes other WPCS fixes

[afragen]

Both of the patches 46937.diff​ and 46937-wpcs.diff​ should fix this issue. The second patch 46937-wpcs.diff​ also updates the modified files for WPCS.

If the host provides their own update URL the following is displayed.

[SergeyBiryukov]

In 45357:

Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.

Additionally, fix a regression in [44451] where the error message in wp-admin/upgrade.php was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Fixes #46937.

[SergeyBiryukov]

In 45358:

Upgrade/Install: Improve error messages displayed when WordPress update fails due to an incompatible PHP version by linking to the Update PHP support page.

Additionally, fix a regression in [44451] where the error message in wp-admin/upgrade.php was prepared, but never displayed.

Props afragen, netweb, hareesh-pillai, SergeyBiryukov.
Merges [45357] to the 5.2 branch.
Fixes #46937.

[TimothyBlynJacobs]

Is there a plan for this to be backported to 5.1 installs? It seems like it'd be helpful to include for those users.

[desrosj]

@TimothyBlynJacobs historically only security changes have been backported past the current working branch. If #47160 is tackled and backported, though, I agree that this should accompany it.