WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46965 closed defect (bug) (fixed)

Site Health: "harddrive" spelling should be "hard drive".

Reported by: chetan200891's profile chetan200891 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-patch commit
Focuses: administration Cc:

Description

On Site Health Info page "harddrive" spelling should be "hard drive".

Attachments (3)

46965.diff​ (1.1 KB) - added by chetan200891 6 years ago.
Created patch.
46965-2.patch​ (1.1 KB) - added by timhavinga 6 years ago.
Replaced "harddrive" with "computer"
46965.1.diff​ (1.1 KB) - added by chetan200891 6 years ago.
Refreshed patch.

Download all attachments as: .zip

Change History (11)

@chetan200891
6 years ago

Created patch.

#1 @SergeyBiryukov
6 years ago

  • Keywords site-health added
  • Milestone changed from Awaiting Review to 5.3

#2 @Cybr
6 years ago

Hard drives are archaic, and the term is technically incorrect when you're speaking of SSDs. It'd be better to change it to "to your computer", or "locally".

This ticket was mentioned in ​Slack in #core-php by timhavinga. ​View the logs.
6 years ago

@timhavinga
6 years ago

Replaced "harddrive" with "computer"

#4 @desrosj
6 years ago

  • Component changed from Text Changes to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#5 @Clorith
6 years ago

  • Keywords needs-refresh added; has-patch removed

Good call on the verbiage, I agree that harddrive is not ideal here. For the average user, they don't distinguish between the type of storage medium, but it makes more sense to use a different term.

Although computer is nice, it's a bit limiting in our current technological landscape, let's use device instead, would either of you like to update the patch to reflect this?

@chetan200891
6 years ago

Refreshed patch.

#6 @chetan200891
6 years ago

  • Keywords needs-refresh removed

@Clorith Patch refreshed.

#7 @Clorith
6 years ago

  • Keywords has-patch commit added
  • Version set to 5.2

#8 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45648:

Site Health: Replace "harddrive" with "device" on Site Health Info screen.

Props chetan200891, timhavinga, Cybr, Clorith.
Fixes #46965.

Note: See TracTickets for help on using tickets.