WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Last modified 8 weeks ago

#46966 new defect (bug)

urlencode query string parameters

Reported by: developernichemarketing's profile developernichemarketing Owned by:
Milestone: Awaiting Review Priority: normal
Severity: major Version:
Component: Formatting Keywords: has-patch needs-testing
Focuses: Cc:

Description

When adding query string arguments to a URL through add_query_arg() the arguments are not being URL encoded.

An example of this

add_query_arg( 'autofocus[panel]', 'themes', admin_url( 'customize.php' ) )

The [ ] characters should URL encoded

Output:
/wp-admin/customize.php?autofocus[panel]=themes

Expected:
/wp-admin/customize.php?autofocus%5Bpanel%5D=themes

Attachments (1)

46966.patch​ (682 bytes) - added by vishalpadhariya 14 months ago.

Download all attachments as: .zip

Change History (4)

@vishalpadhariya
14 months ago

#2 @vishalpadhariya
14 months ago

  • Keywords has-patch needs-testing added; needs-patch removed
  • Version set to trunk

I have fixed the issue with URL-encoding query string parameters. Please find the attached patch.

#3 @wildworks
8 weeks ago

  • Version trunk deleted

Looking at ​the Git Blame, it looks like this code has been around for a few years, so it's not new to the current development branch, so we'll leave the version blank.

Note: See TracTickets for help on using tickets.