WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#47017 closed defect (bug) (fixed)

Blocks: Expose more fields for blocks registered on the server

Reported by: gziolo's profile gziolo Owned by: desrosj's profile desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description (last modified by gziolo)

Discovered when working on Block Registration API RFC (​https://github.com/WordPress/gutenberg/pull/13693) and doing an audit of fields exposed for the blocks registered on the server.

It turns out that there are 2 fields that we need to expose to make it possible to reuse them on the client:

  • styles
  • parent

It looks like there were omitted by accident during 5.0 release because they were never registered on the server in WordPress core.

Attachments (1)

patch.diff​ (739 bytes) - added by gziolo 4 years ago.

Download all attachments as: .zip

Change History (10)

#1 @desrosj
4 years ago

  • Milestone changed from Awaiting Review to Future Release

@gziolo
4 years ago

#2 @gziolo
4 years ago

  • Description modified (diff)

#3 @gziolo
4 years ago

  • Type changed from enhancement to defect (bug)

#4 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 5.3

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
4 years ago

#6 @pierlo
4 years ago

Patch is still valid and can be committed.

#7 @desrosj
4 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#8 @desrosj
4 years ago

  • Keywords has-patch commit added

#9 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46091:

Editor: Add missing block data fields for blocks registered server side.

In [44122], the styles and parent block fields were omitted on accident. This change makes it possible to reuse them on the client.

Props gziolo.
Fixes #47017.

Note: See TracTickets for help on using tickets.