WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4704 closed defect (bug) (fixed)

Invalid RSS2 Comments Feed

Reported by: lexhair Owned by:
Milestone: 2.2.3 Priority: high
Severity: normal Version: 2.2.1
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

Version 2.2.2. My comments RSS2 feed was invalid because the author tags did not enclose a valid email address.

I modified the feed-rss2-comments.php file to include xlmns:dc="http://purl.org/dc/elements/1.1/" in the head space and changed the author tags to dc:creator tags. This validated the comments feed.

I apologize for not submitting the patch as a diff but I'm quite a noob when it comes to this stuff.

Attachments (3)

rss2comments-patch.zip (1.3 KB) - added by lexhair 10 years ago.
Patched feed-rss2-comments.php file for feed validation
4704-222.diff (1018 bytes) - added by Otto42 10 years ago.
dc:creator patch for 2.2.2
4704-trunk.diff (1018 bytes) - added by Otto42 10 years ago.
dc:creator patch for trunk

Download all attachments as: .zip

Change History (11)

#1 @Otto42
10 years ago

  • Keywords has-patch added
  • Milestone set to 2.3 (trunk)
  • Priority changed from normal to high
  • Version set to 2.2.1

Agreed, this causes all comment feeds to be invalid. The author element is supposed to conform to RFC822.

http://cyber.law.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt
http://feedvalidator.org/docs/error/InvalidContact.html

I'm attaching a patch to fix this for 2.2.2. Trunk patch coming soon.

#2 @Otto42
10 years ago

Ahh.. It just occurred to me that it might not be desirable to publish email addresses of comment authors, considering it says that you won't on the default theme page. So... forget the above patch, perhaps the dc:creator would indeed be a better way to go.

#3 @Viper007Bond
10 years ago

Yeah, publishing e-mails = major eww and should be avoided at all costs.

#4 @lexhair
10 years ago

I'll attach my patched feed-rss2-comments.php so if someone wants to make a diff out of it, go for it.

@lexhair
10 years ago

Patched feed-rss2-comments.php file for feed validation

@Otto42
10 years ago

dc:creator patch for 2.2.2

@Otto42
10 years ago

dc:creator patch for trunk

#5 @Otto42
10 years ago

Added dc:creator based patches for 2.2.2 and trunk. These change the author to dc:creator, which eliminates the validation issue.

#6 @ryan
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5881]) Use dc:creator instead of author for rss2 comment feeds. Props lexhair, Otto42. fixes #4704 for 2.3

#7 @ryan
10 years ago

(In [5882]) Use dc:creator instead of author for rss2 comment feeds. Props lexhair, Otto42. fixes #4704 for 2.2

#8 @ryan
10 years ago

  • Milestone changed from 2.3 (trunk) to 2.2.3
Note: See TracTickets for help on using tickets.