#4704 closed defect (bug) (fixed)
Invalid RSS2 Comments Feed
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.2.3 | Priority: | high |
Severity: | normal | Version: | 2.2.1 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description
Version 2.2.2. My comments RSS2 feed was invalid because the author tags did not enclose a valid email address.
I modified the feed-rss2-comments.php file to include xlmns:dc="http://purl.org/dc/elements/1.1/" in the head space and changed the author tags to dc:creator tags. This validated the comments feed.
I apologize for not submitting the patch as a diff but I'm quite a noob when it comes to this stuff.
Attachments (3)
Change History (11)
#1
@
18 years ago
- Keywords has-patch added
- Milestone set to 2.3 (trunk)
- Priority changed from normal to high
- Version set to 2.2.1
#2
@
18 years ago
Ahh.. It just occurred to me that it might not be desirable to publish email addresses of comment authors, considering it says that you won't on the default theme page. So... forget the above patch, perhaps the dc:creator would indeed be a better way to go.
#4
@
18 years ago
I'll attach my patched feed-rss2-comments.php so if someone wants to make a diff out of it, go for it.
#5
@
18 years ago
Added dc:creator based patches for 2.2.2 and trunk. These change the author to dc:creator, which eliminates the validation issue.
Agreed, this causes all comment feeds to be invalid. The author element is supposed to conform to RFC822.
http://cyber.law.harvard.edu/rss/rss.html#ltauthorgtSubelementOfLtitemgt
http://feedvalidator.org/docs/error/InvalidContact.html
I'm attaching a patch to fix this for 2.2.2. Trunk patch coming soon.