#47125 closed defect (bug) (fixed)
Admin: clarify the "Add New" links for better accessibility
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-screenshots has-patch needs-dev-note commit |
Focuses: | ui, accessibility, administration | Cc: |
Description
In the admin menu and in some of the admin pages, various links use "Add New" as link text. While these links are clarified by the visual context, they are not so meaningful when read out of context.
Assistive technologies provide tools to list all the links in a page and dedicated keyboard shortcuts to navigate through links. In this scenario, a link that only says "Add New" isn't sufficiently clear: users won't have a clue what the purpose and destination of the link is.
One more scenario: users who use speech input software (e.g. Dragon) will voice a command like "Click add new". However, in a standard WordPress page there are at least 5 "Add New" links. The software will display choices to users (usually by displaying numbers close to all the links that it has identified as "Add New"). Then, users will have to:
- visually identify on the screen the highlighted links
- voice an additional command, e.g. "Choose 3"
This makes the process inefficient and time consuming.
Ideally, all these links should be self-explanatory and provide more context by adding the "what" new is in the text link. For example:
- Add New Post
- Add New Media
- Add New Page
- Add New Plugin
- Add New User
Attachments (8)
Change History (29)
This ticket was mentioned in Slack in #accessibility by afercia. View the logs.
4 years ago
#3
@
4 years ago
- Milestone changed from Awaiting Review to Future Release
Discussed during today's accessibility bug scrub and agreed this is something that should be addressed, especially for speech recognition software users.
#4
@
4 years ago
I've submitted a patch that updates all "Add New" links (that I could find in the source) together with "Add Existing" links for users and some comments, theme readmes that reference these links. I'm not sure though that my approach for the post types "Add New" menu items is the best one.
#7
@
5 weeks ago
- Focuses administration added
- Keywords needs-testing added
- Milestone changed from Future Release to 6.4
Refreshed the patch.
https://core.trac.wordpress.org/raw-attachment/ticket/47125/47125-patch.2.diff
#8
@
4 weeks ago
Just noting that if this proposed change gets approved we could consider to not use the _x()
translation function any longer. Specifying the context would be pointless as the new strings are already in context. For example:
_x( 'Add New Link', 'link' )
The provided context 'link' is not necessary, as the string is already clear enough.
__( 'Add New Link' )
would be simpler and cleaner.
#9
@
4 weeks ago
Updated the patch to use __()
vs. _x()
.
https://core.trac.wordpress.org/raw-attachment/ticket/47125/47125-patch.3.diff
#10
@
4 weeks ago
- Keywords needs-refresh needs-design-feedback added; needs-testing removed
Thanks for updating the patch. While testing, I noticed there are still around 30 occurrences of 'Add New' in the codebase that would need to be checked. A few of them are in comments or help text but they should be updated as well.
Also, making the search case sensitive I found a couple places where the letter 'n' of the word 'new' is lowercase:
__( 'Add new Pattern' ) _e( 'Add new Comment' )
This is inconsistent with the well established pattern in WordPress, where all similar strings use title case for the word 'New', for example:
__( 'Add New Template' )
'Add new Pattern' was recently Introduced in [56030]
Adding a screenshot to illustrate some examples of what the current patch does.
#11
@
4 weeks ago
Related GitHub issue on the Gutenberg repository: https://github.com/WordPress/gutenberg/issues/53984
#12
@
4 weeks ago
- Keywords needs-refresh removed
Probably not perfect, but I think this moves us closer.
https://core.trac.wordpress.org/attachment/ticket/47125/47125-patch.4.diff
Anything I missed this go around @afercia?
Thanks.
This ticket was mentioned in Slack in #core by marybaum. View the logs.
4 weeks ago
#15
@
4 weeks ago
Looking at 47125-patch.4.diff, I'd slightly adjust the change to the docblock of get_post_type_labels()
Right now it says "Default is 'Add New Type' for both hierarchical and non-hierarchical types." and "matching your post type. Example: __( 'Add New Type' );
."
I would change this to "Default is 'Add New Post' / 'Add New Page'" and "matching your post type. Example: __( 'Add New Product' );
.", respectively.
Also, that change warrants a mentioned in a dev-note somewhere so developers update labels in their plugins.
#17
@
3 weeks ago
Removed a few translator comments that are no longer needed with the removal of _x()
calls. Also restored the 'textdomain' argument in the get_post_type_labels()
docblock, as that is still an important instruction for extenders.
#18
@
3 weeks ago
- Keywords commit added; needs-design-feedback removed
I'm don't see that this requires design feedback. These are all text changes. I don't see anything design wise that requires comment.
I'm marking this for commit. There may be further strings that would merit changing, but I don't think those should stop this from getting resolved; we can always add follow-up commits. I searched the code and there's nothing obvious remaining.
This ticket was mentioned in PR #5140 on WordPress/wordpress-develop by @joedolson.
3 weeks ago
#19
Trac ticket: https://core.trac.wordpress.org/ticket/47125
VoiceOver links list