Opened 7 years ago
Closed 7 years ago
#47238 closed defect (bug) (fixed)
i18n: Avoid using HTML tags in translation strings (wp-admin/plugins.php)
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.3 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Plugins | Keywords: | has-screenshots has-patch 2nd-opinion |
| Focuses: | administration | Cc: |
Description
See the attached patch.
Attachments (2)
Change History (7)
#4
in reply to:
↑ 3
@
7 years ago
For consistency, we should probably remove the markup from all these plugin messages, unless someone can think of a good reason to keep it.
No reason to keep the markup.
If you will check the other action messages you will find the same result (user screen / terms screen / post screen / settings screen / etc.). We rarely emphasis the action. I guess you can find few more strings emphasizing the action, but they are the exception, and we should change them too.
Note: See
TracTickets for help on using
tickets.
The current string is consistent with the other plugin action messages:
The selected plugin(s) have been <strong>deleted</strong>.Plugin <strong>activated</strong>.Selected plugins <strong>activated</strong>.Plugin <strong>deactivated</strong>.Selected plugins <strong>deactivated</strong>.However, similar theme action messages don't have the markup:
Settings saved and theme activated.New theme activated.Theme deleted.These are some of the oldest strings in WordPress (
Plugin <strong>activated</strong>was introduced in [1071];New theme activatedwas introduced in [1655]), and it looks like they have always been like this.For consistency, we should probably remove the markup from all these plugin messages, unless someone can think of a good reason to keep it.