Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47312 closed defect (bug) (fixed)

Replace new "fixed %s bugs" string with a pre-existing one

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: desrosj's profile desrosj
Milestone: 5.2.1 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit dev-reviewed
Focuses: Cc:


[45359] introduced a new string on the About page:

	'<strong>Version %1$s</strong> fixed %2$s bug.',
	'<strong>Version %1$s</strong> fixed %2$s bugs.'

It should be replaced with a pre-existing string:

	'<strong>Version %1$s</strong> addressed %2$s bug.',
	'<strong>Version %1$s</strong> addressed %2$s bugs.'

Attachments (2)

47312.diff (578 bytes) - added by mukesh27 5 years ago.
47312.2.diff (679 bytes) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
5 years ago

  • Summary changed from Replace new "fixed %s" bugs string with a pre-existing one to Replace new "fixed %s bugs" string with a pre-existing one

#2 @mukesh27
5 years ago

@SergeyBiryukov and @desrosj i can't found [45359] changeset in WordPress GIT repo and SVN but those changes are shown in Beta Testing WordPress plugin with Point release nightlies option.

When we got those changes in GIT or in SVN?

#3 @mukesh27
5 years ago

  • Keywords has-patch added

Got it from 5.2-branch in GIT. attached patch for changes.

5 years ago


#4 @desrosj
5 years ago

  • Milestone changed from 5.2.2 to 5.2.1

There's going to be a 5.2.1. RC2 because of #47323. Let's just fix this before release.

#5 @desrosj
5 years ago

  • Keywords commit dev-feedback added

@mukesh27 [45359] was not committed to trunk, only the 5.2 branch.

47312.diff looks good. Tagging for a second review.

#6 follow-up: @desrosj
5 years ago

The number of bugs will also need to be updated to 33 to reflect #47304 being included.

#7 in reply to: ↑ 6 @SergeyBiryukov
5 years ago

Replying to desrosj:

The number of bugs will also need to be updated to 33 to reflect #47304 being included.

With both #47304 and #47323, wouldn't it be 34?

#8 @desrosj
5 years ago

I did not count it because it was a bug introduced during the 5.2.1 cycle and was not something that made it into the wild. I don't feel strongly about not including it, though.

#9 @SergeyBiryukov
5 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Ah, makes sense :) 47312.2.diff updates the count.

#10 @desrosj
5 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 45364:

Help/About: Replace minor release strings with pre-existing ones.

Also, update the number of bugs fixed in 5.2.1 to include those being fixed after RC1.

Reviewed by desrosj, SergeyBiryukov.

Props ocean90, SergeyBiryukov, mukesh27.
Fixes #47312.

Note: See TracTickets for help on using tickets.