Extend Moment.js localization

[swissspidy]

With the Gutenberg integration we also got Moment.js in core with some localization support.

However, only a few of the fields that Moment.js supports are localized in WordPress. If a plugin wants to use some features like relative time (e.g. "%s hours ago"), these bits won't be translated.

I suggest also localizing thinks like relativeTime and potentially others.

See ​https://momentjs.com/docs/#/i18n/ for a full list of things that could be localized in core.

Similar enhancement in the past for jQuery UI datepicker: #29420

[manzoorwani.jk]

It will need the changes in ​this file. I am on it as well.

[manzoorwani.jk]

Here is the corresponding PR to Gutenberg Repo. ​#16728

[manzoorwani.jk]

With the ​PR being merged, I guess this is now ready to go ahead.

[davidbaumwald]

This ticket still needs a review, and with 5.4 Beta 1 landing tomorrow, this is being moved to Future Release. If any maintainer or committer feels this can be included in 5.4 or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[adrianduffell]

If a plugin wants to use some features like relative time (e.g. "%s hours ago"), these bits won't be translated.

This behavior occurs in WooCommerce where relative times are not translated.

Could the patch please be reviewed? Thank you.

[costdev]

With this being raised in Slack recently, this issue is still relevant. The patch looks straightforward and I think we can land it in 6.1.

It would be good to get feedback from someone with more i18n experience than myself.

@swissspidy @SergeyBiryukov what else might this need to move forward?

[JeffPaul]

As discussed ahead of today's scheduled 6.1 Beta 1 release party (see the Slack link above), it was deemed that this ticket was not ready and should be punted to the 6.2 milestone to be reviewed and addressed then.

[hellofromTonya]

Hello all,

I see that Gutenberg's instance got an update. I'm curious:

Does it meet the needs of the enhancement request in this ticket?

If yes, then it might worth someone comparing the latest code ​https://github.com/WordPress/gutenberg/blob/trunk/packages/date/src/index.js#L70 to determine if the patch in this ticket is up-to-date.

[costdev]

This ticket was discussed during the recent bug scrub.

@SergeyBiryukov As the patch may need to be revised, and we're approaching 6.2 Beta 1 on February 7th, is this ticket still on your radar for 6.2, or should it be moved to Future Release?

Additional props: @mukesh27

[mukesh27]

Thanks @swissspidy for the ticket.

This ticket was discussed during the bug scrub. As this ticket still needs discussion and 6.2 Beta 1 is being released today, I'll move this to Future Release.

Additional props: @costdev