WordPress.org

Make WordPress Core

Opened 13 days ago

Last modified 4 days ago

#47478 assigned task (blessed)

Update Backbone.js to 1.4.0

Reported by: desrosj Owned by: priyankkpatel
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: early good-first-bug has-patch needs-testing needs-refresh
Focuses: Cc:

Description

Backbone.js 1.4.0 was released on February 19, 2019.

Core currently includes version 1.3.3 using the package.json file. However, the version indicated when the script is enqueued incorrectly indicates 1.2.3 is loaded.

A full list of changes since 1.3.3 can be found here: https://github.com/jashkenas/backbone/compare/1.3.3...1.4.0.

Attachments (5)

47478.diff (1.3 KB) - added by priyankkpatel 12 days ago.
Patch for wp-includes/script-loader.php
backbone.js (76.0 KB) - added by priyankkpatel 12 days ago.
backbone.js 1.4.0
backbone.min.js (24.4 KB) - added by priyankkpatel 12 days ago.
backbone.min 1.4.0
package-lock.diff (699 bytes) - added by priyankkpatel 4 days ago.
patch for file package-lock.json
47478-2.diff (2.0 KB) - added by priyankkpatel 4 days ago.
Final patch including changes in package.json, package-lock.json and wp-includes/script-loader.php

Download all attachments as: .zip

Change History (10)

@priyankkpatel
12 days ago

Patch for wp-includes/script-loader.php

#1 @priyankkpatel
12 days ago

I have attached patch for wp-includes/script-loader.php and package.json.
package.json will now download Backbone.js version 1.4.0

@priyankkpatel
12 days ago

backbone.js 1.4.0

@priyankkpatel
12 days ago

backbone.min 1.4.0

This ticket was mentioned in Slack in #core by desrosj. View the logs.


4 days ago

#3 follow-up: @desrosj
4 days ago

  • Keywords has-patch needs-testing needs-refresh added; needs-patch removed
  • Owner set to priyankkpatel
  • Status changed from new to assigned

Assigning to @priyankkpatel to mark good-first-bug claimed.

Thanks for the patch! The package-lock.json file will also need to be updated.

@adamsilverstein are you able to help testing this?

#4 in reply to: ↑ 3 @priyankkpatel
4 days ago

Replying to desrosj:

Assigning to @priyankkpatel to mark good-first-bug claimed.

Thanks for the patch! The package-lock.json file will also need to be updated.

@adamsilverstein are you able to help testing this?

You are welcome @desrosj

@priyankkpatel
4 days ago

patch for file package-lock.json

@priyankkpatel
4 days ago

Final patch including changes in package.json, package-lock.json and wp-includes/script-loader.php

#5 @adamsilverstein
4 days ago

Yes, I'll give this a test soon.

Note: See TracTickets for help on using tickets.