Emoji are substituted in preformatted blocks

[jikamens]

I have a preformatted block in a posting that is a shell script. There's a line in the shell script which ends in ":)". When I preview the posting those two characters are replaced by a smiley face. Emoji substitution should not happen inside preformatted blocks.

[pento]

Thank you for the bug report, @jikamens!

The convert_smilies() function is supposed to ignore smilies in <pre> tags, bug it doesn't work correctly if the tag has attributes on it.

47489.diff​ adds support for this case, along with unit tests.

[pento]

In 45569:

Formatting: Don't convert smilies in ignored tags that have attributes.

Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a class to the <pre> tag.

Props pento, jikamens.
Fixes #47489.

[pento]

#44278 was marked as a duplicate.

[JeffPaul]

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

[SergeyBiryukov]

In 45837:

Formatting: Don't convert smilies in ignored tags that have attributes.

Smilies in ignored tags are not supposed to be converted to emoji, but this can malfunction if the tag has attributes. For example, the Preformatted block with add a class to the <pre> tag.

Props pento, jikamens.
Merges [45569] to the 5.2 branch.
Fixes #47489.